Skip to content

fix: unexpected uncalled judge in recursive loop #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timakin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: unexpected uncalled judge in recursive loop #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions call.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,14 @@ func (c *calledFrom) succs(b *ssa.BasicBlock) bool {
return false
}

var called bool
for _, s := range b.Succs {
if !c.instrs(s.Instrs) && !c.succs(s) {
return false
if c.instrs(s.Instrs) || c.succs(s) {
called = true
Copy link
Member

@tenntenn tenntenn Apr 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does not return immediately?

Copy link
Author

@timakin timakin Apr 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a defer function, the index of instr won't be 1.
So the loop will be returned before the Instruction was checked.
For an accurate validation, an iteration for "all of" s.Succs values is needed.

Copy link
Member

@tenntenn tenntenn Apr 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this code only checks whether the function was called in any succsesors yet.
Because there is only an assignment which changes value of var called, called = true.

}
}

return true
return called
}

// CalledFrom checks whether receiver's method is called in an instruction
Expand Down