lf_multi_traffic.py: Run multiple traffic tests in series or parallel.#57
Open
Sidartha-CT wants to merge 1 commit into
Open
lf_multi_traffic.py: Run multiple traffic tests in series or parallel.#57Sidartha-CT wants to merge 1 commit into
Sidartha-CT wants to merge 1 commit into
Conversation
| bool: False if the test was stopped by the user, True otherwise. | ||
| """ | ||
| try: | ||
| print("ENTERED STOP CHECKKK") |
Collaborator
There was a problem hiding this comment.
remove the print statement
| logging.info('Test is stopped by the user') | ||
| self.test_stopped = True | ||
| if not self.test_stopped: | ||
| print("ENTERED NOT STOPPED") |
| pids = stdout.read().decode().strip().splitlines() | ||
|
|
||
| if pids: | ||
| print(f"Processes using port {port}: {', '.join(pids)}") |
| if "zoom_test" in self.parallel_tests: | ||
| logger.info("Waiting for Zoom test rotation to finish") | ||
| self.zoom_rotate_done_event.wait() | ||
| # print("222",self.robot_move_event.is_set(),"---",self.ftp_done_event.is_set(),"---",self.http_done_event.is_set()) |
Collaborator
There was a problem hiding this comment.
Please remove the print statements. It would also be good to mention the function's return values in the docstring.
| """ | ||
| Wait for all active parallel tests to completely finish their execution. | ||
| """ | ||
| # print(self.qos_done_event.is_set(),"---",self.ftp_done_event.is_set(),"---",self.http_done_event.is_set()) |
Collaborator
There was a problem hiding this comment.
return value in doc string
| }) | ||
| df1 = pd.DataFrame(temp_json) | ||
| df1.to_csv('{}/ping_datavalues.csv'.format(self.result_dir), index=False) | ||
| # try: |
Collaborator
There was a problem hiding this comment.
remove the commented lines
| host=mgr_ip, | ||
| port=mgr_port, | ||
| url=url, | ||
| duration=duration, |
Collaborator
There was a problem hiding this comment.
remove commented lines
| host=mgr_ip, | ||
| port=mgr_port, | ||
| url=url, | ||
| duration=duration, |
Collaborator
There was a problem hiding this comment.
remove commented lines
| host=mgr_ip, | ||
| port=mgr_port, | ||
| url=url, | ||
| duration=duration, |
Collaborator
There was a problem hiding this comment.
remove commented lines
| host=mgr_ip, | ||
| port=mgr_port, | ||
| url=url, | ||
| duration=duration, |
Collaborator
There was a problem hiding this comment.
It would be good to add a docstring
| host=mgr_ip, | ||
| port=mgr_port, | ||
| url=url, | ||
| duration=duration, |
Collaborator
There was a problem hiding this comment.
The arguments section is really well segregated @Sidartha-CT
Sidartha-CT
force-pushed
the
multitraffictest
branch
from
791875f to
1a407dd
Compare
Verified CLI : python3 lf_multi_traffic.py --mgr 192.168.247.77 --upstream_port eth2 --parallel_tests ping_test,qos_test,ftp_test,http_test,mcast_test,vs_test,thput_test --ping_target www.google.com --ping_interval 5 --ping_duration 1 --ping_device_list 1.15,1.11,1.23,1.13,1.25,1.18,1.29,1.28,1.30,1.14 --qos_tos VO,VI,BE,BK --qos_duration 1m --qos_device_list 1.15,1.11,1.23,1.13,1.25,1.18,1.29,1.28,1.30,1.14 --qos_traffic_type lf_tcp --qos_download 10000000 --ftp_duration 1m --ftp_file_size 5MB --ftp_device_list 1.15,1.11,1.23,1.13,1.25,1.18,1.29,1.28,1.30,1.14 --ftp_bands 5G --http_duration 1m --http_file_size 5MB --http_device_list 1.15,1.11,1.23,1.13,1.25,1.18,1.29,1.28,1.30,1.14 --http_bands 5G --mcast_tos VO --mcast_test_duration 1m --mcast_side_b_min_bps 10000000 --mcast_device_list 1.15,1.11,1.23,1.13,1.25,1.18,1.29,1.28,1.30,1.14 --mcast_endp_type mc_udp --vs_url https://test-streams.mux.dev/x36xhzz/x36xhzz.m3u8 --vs_media_source hls --vs_media_quality 4k --vs_duration 1m --vs_device_list 1.15,1.11,1.23,1.13,1.25,1.18,1.29,1.28,1.30,1.14 --thput_test_duration 1m --thput_traffic_type lf_udp --thput_device_list 1.15,1.11,1.23,1.13,1.25,1.18,1.29,1.28,1.30,1.14 --thput_upload 10000000 --no_cleanup Signed-off-by: Sidartha-CT <neelapu.sidartha@candelatech.com>
Sidartha-CT
force-pushed
the
multitraffictest
branch
from
1a407dd to
63f06eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified CLI : python3 lf_multi_traffic.py --mgr 192.168.247.77 --upstream_port eth2 --parallel_tests ping_test,qos_test,ftp_test,http_test,mcast_test,vs_test,thput_test --ping_target www.google.com --ping_interval 5 --ping_duration 1 --ping_device_list 1.15,1.11,1.23,1.13,1.25,1.18,1.29,1.28,1.30,1.14 --qos_tos VO,VI,BE,BK --qos_duration 1m --qos_device_list 1.15,1.11,1.23,1.13,1.25,1.18,1.29,1.28,1.30,1.14 --qos_traffic_type lf_tcp --qos_download 10000000 --ftp_duration 1m --ftp_file_size 5MB --ftp_device_list 1.15,1.11,1.23,1.13,1.25,1.18,1.29,1.28,1.30,1.14 --ftp_bands 5G --http_duration 1m --http_file_size 5MB --http_device_list 1.15,1.11,1.23,1.13,1.25,1.18,1.29,1.28,1.30,1.14 --http_bands 5G --mcast_tos VO --mcast_test_duration 1m --mcast_side_b_min_bps 10000000 --mcast_device_list 1.15,1.11,1.23,1.13,1.25,1.18,1.29,1.28,1.30,1.14 --mcast_endp_type mc_udp --vs_url https://test-streams.mux.dev/x36xhzz/x36xhzz.m3u8 --vs_media_source hls --vs_media_quality 4k --vs_duration 1m --vs_device_list 1.15,1.11,1.23,1.13,1.25,1.18,1.29,1.28,1.30,1.14 --thput_test_duration 1m --thput_traffic_type lf_udp --thput_device_list 1.15,1.11,1.23,1.13,1.25,1.18,1.29,1.28,1.30,1.14 --thput_upload 10000000 --no_cleanup