lf_interop_youtube.py : Now the script can run on virtual clients and existing stations as well#63
Open
KowshikVarma-CT wants to merge 1 commit into
Open
lf_interop_youtube.py : Now the script can run on virtual clients and existing stations as well#63KowshikVarma-CT wants to merge 1 commit into
KowshikVarma-CT wants to merge 1 commit into
Conversation
… existing stations as well VERIFIED_CLI: 1.python3 lf_interop_youtube.py --mgr 192.168.207.78 --url "https://youtu.be/BHACKCNDMW8?si=psTEUzrc77p38aU1" --duration 1 --res 1080p --upstream_port 1.1.eth1 --clients_type virtual --num_sta 3 --ssid NETGEAR_2G_Open --passwd NA --encryp open --radio wiphy0 2.python3 lf_interop_youtube.py --mgr 192.168.207.78 --url "https://youtu.be/BHACKCNDMW8?si=psTEUzrc77p38aU1" --duration 1 --res 1080p --upstream_port 1.1.eth1 --clients_type virtual --use_existing_sta_list --existing_sta_list 1.1.sta00,1.1.sta01,1.1.sta02,1.1.sta03 Signed-off-by: KowshikVarma-CT <kowshik.varma@candelatech.com>
Sidartha-CT
reviewed
May 21, 2026
Comment on lines
+564
to
+565
| def map_sta_ips_real(self, sta_list=None): | ||
| if sta_list is None: |
Collaborator
There was a problem hiding this comment.
Add docstring comment function's functionality
Sidartha-CT
reviewed
May 21, 2026
Comment on lines
+575
to
+576
| def convert_to_dict(self, input_list): | ||
| """ |
Sidartha-CT
reviewed
May 21, 2026
Comment on lines
+2745
to
+2746
| def buildstation(self): | ||
| logging.info('Creating Stations {}'.format(self.sta_list)) |
Sidartha-CT
reviewed
May 21, 2026
Comment on lines
+2801
to
+2806
| def stop_specific(self): | ||
| self.http_profile.stop_cx() | ||
|
|
||
|
|
||
| def validate_args(args): | ||
| if args.expected_passfail_value is not None and args.device_csv_name is not None: |
Sidartha-CT
reviewed
May 21, 2026
| logging.error("Please provide ssid password and security for configuration of devices") | ||
| exit(0) | ||
|
|
||
| validate_args(args) |
Collaborator
There was a problem hiding this comment.
it would be better ig validate args change to seperate commit
Sidartha-CT
reviewed
May 21, 2026
Collaborator
Sidartha-CT
left a comment
There was a problem hiding this comment.
@KowshikVarma-CT , Please add docstring comments for functions, which you have added and visibile in diff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
Updated the Selenium automation file used to trigger the Chrome browser for YouTube streaming after starting the cross connections.
File Location
Modified Selenium File
https://drive.google.com/file/d/19MQ7vmNPwRTDFKmo2fo0XjPv9YNeuU6w/view?usp=sharing
Steps to Apply the Changes