Skip to content

lf_interop_youtube.py : Now the script can run on virtual clients and existing stations as well#63

Open
KowshikVarma-CT wants to merge 1 commit into
masterfrom
youtube_virtual2
Open

lf_interop_youtube.py : Now the script can run on virtual clients and existing stations as well#63
KowshikVarma-CT wants to merge 1 commit into
masterfrom
youtube_virtual2

Conversation

@KowshikVarma-CT
Copy link
Copy Markdown
Collaborator

Changes Made

Updated the Selenium automation file used to trigger the Chrome browser for YouTube streaming after starting the cross connections.

File Location

/home/lanforge/yt_l4_video_stream.py

Modified Selenium File

https://drive.google.com/file/d/19MQ7vmNPwRTDFKmo2fo0XjPv9YNeuU6w/view?usp=sharing

Steps to Apply the Changes

  1. Open the modified Selenium file from the link above.
  2. Copy the updated file contents.
  3. Replace the contents of:
    /home/lanforge/yt_l4_video_stream.py
  4. Save the file.
  5. Start the test execution.

… existing stations as well

VERIFIED_CLI:

1.python3 lf_interop_youtube.py --mgr 192.168.207.78 --url "https://youtu.be/BHACKCNDMW8?si=psTEUzrc77p38aU1" --duration 1 --res 1080p --upstream_port 1.1.eth1 --clients_type virtual --num_sta 3 --ssid NETGEAR_2G_Open --passwd NA  --encryp open --radio wiphy0

2.python3 lf_interop_youtube.py --mgr 192.168.207.78 --url "https://youtu.be/BHACKCNDMW8?si=psTEUzrc77p38aU1" --duration 1 --res 1080p --upstream_port 1.1.eth1 --clients_type virtual --use_existing_sta_list --existing_sta_list 1.1.sta00,1.1.sta01,1.1.sta02,1.1.sta03

Signed-off-by: KowshikVarma-CT <kowshik.varma@candelatech.com>
Comment on lines +564 to +565
def map_sta_ips_real(self, sta_list=None):
if sta_list is None:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add docstring comment function's functionality

Comment on lines +575 to +576
def convert_to_dict(self, input_list):
"""
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring here

Comment on lines +2745 to +2746
def buildstation(self):
logging.info('Creating Stations {}'.format(self.sta_list))
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring comment

Comment on lines +2801 to +2806
def stop_specific(self):
self.http_profile.stop_cx()


def validate_args(args):
if args.expected_passfail_value is not None and args.device_csv_name is not None:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add docstrings here

logging.error("Please provide ssid password and security for configuration of devices")
exit(0)

validate_args(args)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better ig validate args change to seperate commit

Copy link
Copy Markdown
Collaborator

@Sidartha-CT Sidartha-CT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KowshikVarma-CT , Please add docstring comments for functions, which you have added and visibile in diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants