Conversation
- Modified validate_args() to convert --client_type values to lowercase so all client type validations can be handled in lowercase format regardless of user input case Signed-off-by: durga-ct <prasad.bandi@candelatech.com>
- Added validation in set_values() to exit the test when self.band == "Both" and the number of stations is 1 Signed-off-by: durga-ct <prasad.bandi@candelatech.com>
…pport - Added support for existing_stations - Added support for: - real + virtual - real + existing_stations - Skipped precleanup when using existing stations - Skipped station cleanup for existing stations - Added mac_id_list and rssi_list handling in get_device_details() - Added interop flag support while creating CXs - Added individual SSID and security handling for real, virtual, and existing station scenarios - Updated pass/fail handling for all supported scenarios Signed-off-by: durga-ct <prasad.bandi@candelatech.com>
Sidartha-CT
reviewed
May 22, 2026
Comment on lines
+1425
to
+1443
|
|
||
| df.insert(0, "band", band) | ||
| df.insert(1, "direction", direction) | ||
| df.insert(2, "filesize", file_size) | ||
|
|
||
| df1.insert(0, "band", band) | ||
| df1.insert(1, "direction", direction) | ||
| df1.insert(2, "filesize", file_size) | ||
|
|
||
| df.to_csv("all_l4_data.csv", | ||
| mode='a', | ||
| header=not os.path.exists("all_l4_data.csv"), | ||
| index=False) | ||
| df1.to_csv( | ||
| "all_" + main_csv_file, | ||
| mode='a', | ||
| header=not os.path.exists("all_" + main_csv_file), | ||
| index=False | ||
| ) |
Collaborator
There was a problem hiding this comment.
add inline comment about the structure of the df,df1
Sidartha-CT
requested changes
May 22, 2026
Sidartha-CT
reviewed
May 22, 2026
| Command Line Interface to run download scenario for existing stations | ||
| python3 lf_ftp.py --file_sizes 1MB --mgr 192.168.207.78 --traffic_duration 1m --directions Download --bands 2.4G | ||
| --use_existing_sta_list --existing_sta_list 1.1.sta00000,1.1.sta00001,1.1.sta00002 | ||
| python3 lf_ftp.py --file_sizes 1MB --mgr 192.168.207.78 --traffic_duration 1m --directions Download --bands 2.4G --use_existing_sta_list --existing_sta_list 1.1.sta00000,1.1.sta00001,1.1.sta00002 |
Collaborator
There was a problem hiding this comment.
revert to its orginal.
Sidartha-CT
requested changes
May 22, 2026
- Added runtime CSV generation for all supported scenarios - Added os_type, RSSI, BSSID, and client_type details to the report Signed-off-by: durga-ct <prasad.bandi@candelatech.com>
- Added timebreak flag to collect data at specified time intervals during test execution VERIFIED_CLI: 1.python3 lf_ftp.py --ssid NETGEAR_5G_wpa2 --passwd Password@123 --file_sizes 1MB --mgr 192.168.207.78 --traffic_duration 1m --security wpa2 --directions Download --clients_type both --bands 5G --upstream_port eth1 --fiveg_radio wiphy1 --num_station 3 --timebreak 10 Signed-off-by: durga-ct <prasad.bandi@candelatech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.