Skip to content

Allow swizzle assignment with language feature#4590

Merged
sudonatalie merged 2 commits intogpuweb:mainfrom
sudonatalie:allow-swizzle-assignment
Feb 12, 2026
Merged

Allow swizzle assignment with language feature#4590
sudonatalie merged 2 commits intogpuweb:mainfrom
sudonatalie:allow-swizzle-assignment

Conversation

@sudonatalie
Copy link
Contributor

Modify the couple tests that check that swizzle assignment does not compile to instead conditionally expect successful compilation based on whether the swizzle_assignment language feature flag is available.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

Modify the couple tests that check that swizzle assignment does not
compile to instead conditionally expect successful compilation based on
whether the swizzle_assignment language feature flag is available.
@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Results for build job (at 89d09ed):

 Test case/subcase counts did not change.

@sudonatalie sudonatalie requested a review from dj2 February 12, 2026 16:29
@sudonatalie sudonatalie enabled auto-merge (squash) February 12, 2026 18:26
@sudonatalie sudonatalie merged commit df0dced into gpuweb:main Feb 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants