Skip to content

Give swizzle assignment cases names and update listing_meta.json#4591

Merged
kainino0x merged 1 commit intogpuweb:mainfrom
sudonatalie:listing-meta
Feb 12, 2026
Merged

Give swizzle assignment cases names and update listing_meta.json#4591
kainino0x merged 1 commit intogpuweb:mainfrom
sudonatalie:listing-meta

Conversation

@sudonatalie
Copy link
Contributor

@sudonatalie sudonatalie commented Feb 12, 2026

Modify the swizzle assignment tests to give them named cases (to satisfy the name length requirements failing on the bots), and update listing_meta.json to add some recently introduced tests that weren't included


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@github-actions
Copy link

github-actions bot commented Feb 12, 2026

Results for build job (at e479eec):

 Test case/subcase counts did not change.

@kainino0x
Copy link
Collaborator

Hm, it's failing the test query name length check...
Take a look at the error but if it's not easy to deal with, then I think it's OK to just leave these out for now.
I'll look into whether we still need this metadata at all.

Error: Generated test variant would produce too-long -actual.txt filename. Possible solutions:
  - Reduce the length of the parts of the test query
  - Reduce the parameterization of the test
  - Make the test function faster and regenerate the listing_meta entry
  - Reduce the specificity of test expectations (if you're using them)
|<------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------>|
webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_local_var:case={"elemType":"u32","vecSize":4,"initial":[1,2,3,5],"swizzle":"xy","rhs":"vec2u(6,%207)","expected":[6,7,3,5]};*
webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_local_var:case={"elemType":"u32","vecSize":4,"initial":[6,7,3,5],"swizzle":"zx","rhs":"vec2u(8,%209)","expected":[9,7,8,5]};*
webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_local_var:case={"elemType":"u32","vecSize":4,"initial":[1,1,1,1],"swizzle":"xyzw","rhs":"vec4u(10,%2011,%2012,%2013)","expected":[10,11,12,13]};*
webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_local_var:case={"elemType":"u32","vecSize":4,"initial":[10,11,12,13],"swizzle":"xy","rhs":"vec2(v.y,%20v.x)","expected":[11,10,12,13]};*
webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_local_var:case={"elemType":"i32","vecSize":3,"initial":[-10,-20,-30],"swizzle":"y","rhs":"-50","expected":[-10,-50,-30]};*
webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_local_var:case={"elemType":"i32","vecSize":3,"initial":[10,20,30],"swizzle":"zx","rhs":"vec2i(40,%2060)","expected":[60,20,40]};*
webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_local_var:case={"elemType":"f32","vecSize":3,"initial":[1,2,3],"swizzle":"xy","rhs":"vec2f(4.0,%205.0)","expected":[4,5,3]};*
webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_local_var:case={"elemType":"f32","vecSize":2,"initial":[1,2],"swizzle":"yx","rhs":"v%20%2B%20v","expected":[4,2]};*
webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_local_var:case={"elemType":"f32","vecSize":4,"initial":[10,20,30,100],"swizzle":"rgb","rhs":"vec3f(v.r,%20v.g,%20v.b)%20%2F%2010","expected":[1,2,3,100]};*
webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_local_var:case={"elemType":"f16","vecSize":2,"initial":[1,2],"swizzle":"yx","rhs":"vec2h(4.0,%205.0)","expected":[5,4]};*
webgpu:shader,execution,statement,swizzle_assignment:swizzle_assignment_local_var:case={"elemType":"bool","vecSize":3,"initial":[1,1,1],"swizzle":"xz","rhs":"vec2%3Cbool%3E(false,%20false)","expected":[0,1,0]};*

@kainino0x
Copy link
Collaborator

Filed #4592

@sudonatalie sudonatalie changed the title Update listing_meta.json Give swizzle assignment cases names and update listing_meta.json Feb 12, 2026
@sudonatalie
Copy link
Contributor Author

Thanks, I think that is actually a valuable error to come up even if it's in an odd roundabout way here. Gave the cases some names.

Modify the swizzle assignment tests to give them named cases (to satisfy
the name length requirements of cases), and update listing_meta.json for
recently added tests that weren't included.
Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kainino0x kainino0x merged commit f93e7e2 into gpuweb:main Feb 12, 2026
1 check passed
@sudonatalie sudonatalie deleted the listing-meta branch February 13, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants