Skip to content

migrate cy ct to storybook #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spaenleh wants to merge 7 commits into
base: main
Choose a base branch
from
Open

migrate cy ct to storybook #1217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6feb08c
fix: upgrade to rolldown-vite
spaenleh Mar 13, 2026
b02a886
fix: upgrade to vite v8
spaenleh Mar 13, 2026
c0cf7b7
fix: update tsconfig to fix issue with paths
spaenleh Mar 13, 2026
3ac7784
fix: update tests
spaenleh Mar 13, 2026
c7fc2b2
fix: disable component testing for now
spaenleh Mar 13, 2026
f830f1b
fix: migrate cypress CT to storybook
spaenleh Mar 13, 2026
7590463
fix: update storybook
spaenleh Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,21 +67,21 @@ jobs:
run: pnpm cypress install

# use the Cypress GitHub Action to run Cypress Component tests within the chrome browser
- name: Cypress run components
uses: cypress-io/github-action@v6
with:
install: false
component: true
browser: chrome
quiet: true
config-file: cypress.config.ts
env:
VITE_PORT: ${{ vars.VITE_PORT }}
VITE_VERSION: ${{ vars.VITE_VERSION }}
VITE_GRAASP_API_HOST: ${{ vars.VITE_GRAASP_API_HOST }}
VITE_GRAASP_LIBRARY_HOST: ${{ vars.VITE_GRAASP_LIBRARY_HOST }}
VITE_SHOW_NOTIFICATIONS: ${{ vars.VITE_SHOW_NOTIFICATIONS }}
VITE_GRAASP_REDIRECTION_HOST: ${{ vars.VITE_GRAASP_REDIRECTION_HOST }}
# - name: Cypress run components
# uses: cypress-io/github-action@v6
# with:
# install: false
# component: true
# browser: chrome
# quiet: true
# config-file: cypress.config.ts
# env:
# VITE_PORT: ${{ vars.VITE_PORT }}
# VITE_VERSION: ${{ vars.VITE_VERSION }}
# VITE_GRAASP_API_HOST: ${{ vars.VITE_GRAASP_API_HOST }}
# VITE_GRAASP_LIBRARY_HOST: ${{ vars.VITE_GRAASP_LIBRARY_HOST }}
# VITE_SHOW_NOTIFICATIONS: ${{ vars.VITE_SHOW_NOTIFICATIONS }}
# VITE_GRAASP_REDIRECTION_HOST: ${{ vars.VITE_GRAASP_REDIRECTION_HOST }}

# use the Cypress GitHub Action to run Cypress tests within the chrome browser
- name: Cypress
Expand Down
5 changes: 2 additions & 3 deletions .storybook/preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { I18nextProvider } from 'react-i18next';

import { CssBaseline, ThemeProvider } from '@mui/material';

import type { Preview, StoryContext } from '@storybook/react';
import type { Preview, StoryContext } from '@storybook/react-vite';
import {
RouterProvider,
createMemoryHistory,
Expand Down Expand Up @@ -39,8 +39,7 @@ const preview: Preview = {
{ value: 'ltr', title: 'left-to-right' },
{ value: 'rtl', title: 'right-to-left' },
],
// Property that specifies if the name of the item will be displayed
showName: true,

// Change title based on selected value
dynamicTitle: true,
},
Expand Down
6 changes: 3 additions & 3 deletions .storybook/vitest.setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { setProjectAnnotations } from '@storybook/react';
import { setProjectAnnotations } from '@storybook/react-vite';
import { beforeAll } from 'vitest';

import * as projectAnnotations from './preview';

// This is an important step to apply the right configuration when testing your stories.
// More info at: https://storybook.js.org/docs/api/portable-stories/portable-stories-vitest#setprojectannotations
const project = setProjectAnnotations([projectAnnotations]);
const annotations = setProjectAnnotations([projectAnnotations]);

beforeAll(project.beforeAll);
beforeAll(annotations.beforeAll);
14 changes: 7 additions & 7 deletions cypress.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ export default defineConfig({
requestTimeout: 8000,
numTestsKeptInMemory: 25,
},
component: {
devServer: {
framework: 'react',
bundler: 'vite',
},
env: ENV,
},
// component: {
// devServer: {
// framework: 'react',
// bundler: 'vite',
// },
// env: ENV,
// },
experimentalMemoryManagement: true,
});
81 changes: 0 additions & 81 deletions cypress/components/common/DebouncedTextField.cy.tsx
View file
Open in desktop

This file was deleted.

48 changes: 23 additions & 25 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
"@mui/material": "7.3.8",
"@sentry/react": "9.47.1",
"@tanstack/react-query": "5.90.21",
"@tanstack/react-router": "1.136.8",
"@tanstack/router-devtools": "1.136.8",
"@tanstack/zod-adapter": "1.136.8",
"@tanstack/react-router": "1.166.7",
"@tanstack/router-devtools": "1.166.7",
"@tanstack/zod-adapter": "1.166.7",
"axios": "1.13.6",
"date-fns": "4.1.0",
"http-status-codes": "2.3.0",
Expand Down Expand Up @@ -80,7 +80,6 @@
"recharts": "2.15.1",
"remark-breaks": "4.0.0",
"remark-gfm": "4.0.1",
"social-links": "1.15.0",
"stylis": "4.3.6",
"use-supercluster": "1.2.0",
"uuid": "11.1.0",
Expand Down Expand Up @@ -137,14 +136,13 @@
"@eslint/eslintrc": "3.3.4",
"@eslint/js": "9.36.0",
"@hey-api/openapi-ts": "0.84.4",
"@storybook/addon-a11y": "9.1.19",
"@storybook/addon-docs": "9.1.19",
"@storybook/addon-links": "9.1.19",
"@storybook/addon-vitest": "^9.0.11",
"@storybook/react": "9.1.19",
"@storybook/react-vite": "9.1.19",
"@tanstack/react-query-devtools": "5.90.2",
"@tanstack/router-plugin": "1.136.18",
"@storybook/addon-a11y": "10.2.17",
"@storybook/addon-docs": "10.2.17",
"@storybook/addon-links": "10.2.17",
"@storybook/addon-vitest": "10.2.17",
"@storybook/react-vite": "10.2.17",
"@tanstack/react-query-devtools": "5.91.3",
"@tanstack/router-plugin": "1.166.7",
"@testing-library/dom": "10.4.1",
"@testing-library/jest-dom": "6.9.1",
"@testing-library/react": "16.3.2",
Expand All @@ -167,10 +165,11 @@
"@types/stylis": "4.2.7",
"@typescript-eslint/eslint-plugin": "8.45.0",
"@typescript-eslint/parser": "8.45.0",
"@vitejs/plugin-react": "5.0.4",
"@vitest/browser": "3.2.4",
"@vitest/coverage-v8": "3.2.4",
"@vitest/ui": "3.2.4",
"@vitejs/plugin-react": "6.0.0",
"@vitest/browser": "4.1.0",
"@vitest/browser-playwright": "4.1.0",
"@vitest/coverage-v8": "4.1.0",
"@vitest/ui": "4.1.0",
"concurrently": "9.2.1",
"cypress": "15.6.0",
"env-cmd": "10.1.0",
Expand All @@ -182,24 +181,23 @@
"eslint-plugin-react": "7.37.5",
"eslint-plugin-react-hooks": "5.2.0",
"eslint-plugin-react-refresh": "0.4.26",
"eslint-plugin-storybook": "9.1.19",
"eslint-plugin-storybook": "10.2.17",
"globals": "15.15.0",
"happy-dom": "20.0.11",
"husky": "9.1.7",
"jose": "5.10.0",
"nock": "13.5.6",
"nyc": "17.1.0",
"oxlint": "1.19.0",
"oxlint": "1.55.0",
"playwright": "1.55.1",
"prettier": "3.6.2",
"storybook": "9.1.19",
"storybook": "10.2.17",
"typescript": "5.9.3",
"vite": "7.1.12",
"vite-plugin-checker": "0.11.0",
"vite-plugin-istanbul": "7.2.1",
"vite-plugin-static-copy": "3.1.6",
"vite-tsconfig-paths": "5.1.4",
"vitest": "3.2.4"
"vite": "8.0.0",
"vite-plugin-checker": "0.12.0",
"vite-plugin-istanbul": "8.0.0",
"vite-plugin-static-copy": "3.3.0",
"vitest": "4.1.0"
},
"volta": {
"node": "22.22.1"
Expand Down
Loading
Loading