Open
Conversation
SimonMarquis
force-pushed
the
hide-obsolete-job-summaries
branch
from
bd737e2 to
d89d244
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<!-- gradle-job-summary: ${jobCorrelator} -->marker on each job summaryI tried to add some tests, but I'm not familiar enough to setup a complete test suite with proper mocking of GitHub/Octokit with jest.
I could potentially extract the
prCommentcreation to check for the marker presence, let me know.Note: it seems like there is currently an issue on mutating comments as
OUTDATEDthrough graphql. Although it does not work as expected (flagging as OUTDATED) the comments are still minimized, which is what we want.Implements #176