Skip to content

Adhoc: improved collapsible state#1403

Merged
kristinademeshchik merged 10 commits intomainfrom
KD/improve-collapsible-state
Mar 24, 2026
Merged

Adhoc: improved collapsible state#1403
kristinademeshchik merged 10 commits intomainfrom
KD/improve-collapsible-state

Conversation

@kristinademeshchik
Copy link
Copy Markdown
Contributor

@kristinademeshchik kristinademeshchik commented Mar 19, 2026

Before:
image

After:
image

default state remains unchanged
image

loading state

image
📦 Published PR as canary version: 7.1.8--canary.1403.23498215848.0

✨ Test out this PR locally via:

npm install @grafana/scenes@7.1.8--canary.1403.23498215848.0
npm install @grafana/scenes-react@7.1.8--canary.1403.23498215848.0
# or 
yarn add @grafana/scenes@7.1.8--canary.1403.23498215848.0
yarn add @grafana/scenes-react@7.1.8--canary.1403.23498215848.0

@kristinademeshchik kristinademeshchik added the release Create a release when this pr is merged label Mar 19, 2026
Comment thread packages/scenes/src/variables/adhoc/AdHocFiltersCombobox/AdHocFiltersCombobox.tsx Outdated
@mdvictor
Copy link
Copy Markdown
Collaborator

This looks great! One mention on adding new filters -- i think we should uncollapse on input click too otherwise there is this I think weird behaviour where we are adding a new filter beyond the +5 counter pill e.g. here

Screen.Recording.2026-03-24.at.14.53.11.mov

Also, but I think this is for another PR, we probably need to 100% width the entire filters input so we dont get this jumping around. Again, not related to this PR

Screen.Recording.2026-03-24.at.14.55.49.mov

@kristinademeshchik
Copy link
Copy Markdown
Contributor Author

This looks great! One mention on adding new filters -- i think we should uncollapse on input click too otherwise there is this I think weird behaviour where we are adding a new filter beyond the +5 counter pill e.g. here

Screen.Recording.2026-03-24.at.14.53.11.mov
Also, but I think this is for another PR, we probably need to 100% width the entire filters input so we dont get this jumping around. Again, not related to this PR

Screen.Recording.2026-03-24.at.14.55.49.mov

both are good point
I will address the first one
And for the second one, I did plan to get back to this to work on better UX after higher priority things are in order

@kristinademeshchik
Copy link
Copy Markdown
Contributor Author

@mdvictor this is now expending on ficus ✅

Copy link
Copy Markdown
Collaborator

@mdvictor mdvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kristinademeshchik kristinademeshchik merged commit 2558afd into main Mar 24, 2026
14 checks passed
@kristinademeshchik kristinademeshchik deleted the KD/improve-collapsible-state branch March 24, 2026 15:49
@scenes-repo-bot-access-token
Copy link
Copy Markdown

🚀 PR was released in v7.1.8 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Create a release when this pr is merged released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants