Ng/improve error handling#307
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error handling across the server by wrapping key operations in try/catch blocks, logging failures, and returning standardized error responses.
- Added
try/catchin HTTP route handlers to catch, log, and respond to errors. - Wrapped broadcast functions with
try/catchto prevent unhandled exceptions during WebSocket operations. - Introduced a WebSocket
'error'listener andtry/catchin message processing for safer message handling.
Comments suppressed due to low confidence (2)
apps/server/src/index.ts:361
- Inconsistent error response formats: this handler uses plain text while the outer catch returns JSON. Standardize on a single JSON error schema (e.g.,
{ message: string }) across all endpoints.
res.status(401).send('Unauthorized');
apps/server/src/index.ts:600
- New error-handling branches in broadcast functions (e.g.,
broadcastSpaceEvents) are not covered by tests. Consider adding unit or integration tests to verify that errors during broadcasting are logged and that the system remains stable.
try {
| res.status(401).send('Unauthorized'); | ||
| return; | ||
| } | ||
| try { |
There was a problem hiding this comment.
[nitpick] Nested try/catch blocks in the /whoami route lead to redundant error handling. Consider consolidating into a single try/catch to simplify the flow and avoid duplicate catches.
| inboxes, | ||
| }; | ||
| res.status(200).send(outgoingMessage); | ||
| try { |
There was a problem hiding this comment.
[nitpick] The repeated pattern of adding try/catch to each route suggests extracting common error handling into Express middleware or a helper function to reduce duplication and improve maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.