Skip to content

fix server deploy by including the entire packages after typesync introduction#483

Merged
nikgraf merged 1 commit into
mainfrom
ng/fix-server-deploy
Aug 15, 2025
Merged

fix server deploy by including the entire packages after typesync introduction#483
nikgraf merged 1 commit into
mainfrom
ng/fix-server-deploy

Conversation

@nikgraf
Copy link
Copy Markdown
Collaborator

@nikgraf nikgraf commented Aug 14, 2025

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a Docker deployment issue by simplifying the inclusion of workspace packages in the Docker image after the introduction of typesync. The change updates the .dockerignore file to include entire package directories rather than specifying individual files.

Key Changes

  • Simplified Docker package inclusion by replacing granular file patterns with directory-level patterns
  • Removed specific file inclusions for packages/hypergraph and packages/hypergraph-react
  • Added broad directory inclusions for the same packages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .dockerignore
!packages/hypergraph/tsconfig.json
!packages/hypergraph/tsconfig.src.json
!packages/hypergraph/tsconfig.build.json
!packages/hypergraph
Copy link

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including the entire package directory may introduce unnecessary files into the Docker image that could increase build size and potentially expose sensitive files. Consider explicitly including only the necessary files like package.json, src/, and tsconfig files as in the original pattern.

Suggested change
!packages/hypergraph
!packages/hypergraph/package.json
!packages/hypergraph/tsconfig.json
!packages/hypergraph/tsup.config.ts
!packages/hypergraph/src

Copilot uses AI. Check for mistakes.
Comment thread .dockerignore
!packages/hypergraph-react/tsconfig.json
!packages/hypergraph-react/tsconfig.src.json
!packages/hypergraph-react/tsconfig.build.json No newline at end of file
!packages/hypergraph-react No newline at end of file
Copy link

Copilot AI Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including the entire package directory may introduce unnecessary files into the Docker image that could increase build size and potentially expose sensitive files. Consider explicitly including only the necessary files like package.json, src/, and tsconfig files as in the original pattern.

Suggested change
!packages/hypergraph-react
!packages/hypergraph-react/package.json
!packages/hypergraph-react/tsconfig.json
!packages/hypergraph-react/tsup.config.ts
!packages/hypergraph-react/src

Copilot uses AI. Check for mistakes.
@nikgraf nikgraf merged commit eeffc5f into main Aug 15, 2025
6 checks passed
@nikgraf nikgraf deleted the ng/fix-server-deploy branch August 15, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants