fix ts check#507
Merged
Merged
Conversation
0925326 to
1ef2dba
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses TypeScript compilation issues by updating TypeScript configurations, fixing import paths, and correcting type definitions. The changes ensure the project builds correctly with proper type checking across all packages and applications.
Key changes include:
- Standardized TypeScript configuration with proper output directories and build settings
- Updated package paths and imports to resolve module resolution issues
- Fixed type definitions and import statements throughout the codebase
Reviewed Changes
Copilot reviewed 27 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.base.json | Removed empty line for cleaner formatting |
| packages//tsconfig..json | Added outDir and noEmit configurations for proper build output |
| package.json | Updated TypeScript check command to use project references |
| apps/template-*/tsconfig.json | Added workspace package path mappings |
| apps/server/* | Fixed Prisma import paths and type definitions |
| apps/events/* | Corrected route parameter naming and import statements |
| apps/connect/src/routes/authenticate.tsx | Removed unused variable assignment |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #507