Skip to content

NM-325: QR Code Size Limits#4000

Open
VishalDalwadi wants to merge 1 commit intodevelopfrom
NM-325
Open

NM-325: QR Code Size Limits#4000
VishalDalwadi wants to merge 1 commit intodevelopfrom
NM-325

Conversation

@VishalDalwadi
Copy link
Copy Markdown
Collaborator

Describe your changes

Size restriction causes the qr code generation to fail for larger extclient configs (ones with lots of allowed ips). Keeping it variable ensures all qr codes generate successfully.

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

Size restriction causes the qr code generation to fail for larger extclient configs (ones with lots of allowed ips). Keeping it variable ensures all qr codes generate successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants