Skip to content

Fix: failed to get ingress gateway node error#4002

Open
VishalDalwadi wants to merge 1 commit intodevelopfrom
fix/gw-not-found
Open

Fix: failed to get ingress gateway node error#4002
VishalDalwadi wants to merge 1 commit intodevelopfrom
fix/gw-not-found

Conversation

@VishalDalwadi
Copy link
Copy Markdown
Collaborator

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@tenki-reviewer
Copy link
Copy Markdown
Contributor

tenki-reviewer Bot commented May 5, 2026

Tenki Code Review - Complete

Files Reviewed: 1
Findings: 0


This PR correctly guards gwClient field population behind the found flag, preventing writes to a zero-value ExtClient struct when no matching ext-client exists for a given ingress gateway. The change is a clean, targeted bug fix with no issues identified.

Files Reviewed (1 files)
pro/controllers/users.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant