Ookla Speedtest Android automation to work with lf_interop_speedtest#266
Open
AbhishekCandela wants to merge 2 commits into
Open
Ookla Speedtest Android automation to work with lf_interop_speedtest#266AbhishekCandela wants to merge 2 commits into
AbhishekCandela wants to merge 2 commits into
Conversation
…speedtest Signed-off-by: AbhishekCandela <rachakonda.abhishek@candelatech.com>
Collaborator
smileyrekiere
left a comment
There was a problem hiding this comment.
curious the Ookla Speedtest script uses prints instead of the logger functionality, also the help is a bit light. Here are the guide lines for the header information
https://candelatech.atlassian.net/wiki/spaces/LANFORGE/history/938934277/Script+Expectations+Code+Style+Docs
Look for Template Script Header, also please include a --help_summary
If this script is an exception of some sort , please advice
44c11c3#top
11:38 AM
There is an example in the PR yet not in the script.
smileyrekiere
approved these changes
May 25, 2026
Collaborator
smileyrekiere
left a comment
There was a problem hiding this comment.
This is a core module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Testing
--type adb--type ookla--type cli--adb_devices