changed printing suspicious distances to status_file not stderr#32
Open
richardjgowers wants to merge 1 commit intogreglandrum:masterfrom
Open
changed printing suspicious distances to status_file not stderr#32richardjgowers wants to merge 1 commit intogreglandrum:masterfrom
richardjgowers wants to merge 1 commit intogreglandrum:masterfrom
Conversation
(trying to avoid spamming stderr) simplified distance_matrix to only build symbol array if needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've got a few 0.99 distances and my stderr gets a lot of stuff, which isn't ideal for library use. Is it ok to use status_file or should there be some sort of error file?