Fix reader macro handling in namespace :require forms (fixes #111)#112
Open
scgerkin wants to merge 2 commits intogreglook:mainfrom
Open
Fix reader macro handling in namespace :require forms (fixes #111)#112scgerkin wants to merge 2 commits intogreglook:mainfrom
scgerkin wants to merge 2 commits intogreglook:mainfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
- Coverage 89.94% 89.83% -0.11%
==========================================
Files 20 20
Lines 1929 1928 -1
Branches 59 59
==========================================
- Hits 1735 1732 -3
- Misses 135 137 +2
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scgerkin
commented
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #111
Fixes reader macro handling in :require forms by treating reader macros as comments that attach to the following dependency rather than as independent, sortable elements.
:mapcase tolibspec-sort-keyto handle complex reader macros like#_{:key value}by treating them as:unevalparse-list-with-commentsto treat:unevalreader macros as comments that accumulate with regular comments and attach to the next dependency