Fix test suite for duration formatting, not assuming locale#114
Open
avocade wants to merge 1 commit intogreglook:mainfrom
Open
Fix test suite for duration formatting, not assuming locale#114avocade wants to merge 1 commit intogreglook:mainfrom
avocade wants to merge 1 commit intogreglook:mainfrom
Conversation
tests failed on my Swedish locale before, due to diff between eg `43,5` and `43.5`. modified tests to explicitly set the locale for the formatter. now all tests pass as they should.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=======================================
Coverage 89.94% 89.94%
=======================================
Files 20 20
Lines 1929 1929
Branches 59 59
=======================================
Hits 1735 1735
Misses 135 135
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests failed on my Swedish locale before, due to diff between eg
43,5and43.5. modified tests to explicitly set the locale for the formatter. now all tests pass as they should.Fixes issue #113