Draft
Conversation
Member
|
Hi @JordiManyer , what is the status of this PR? Have you tried the new implementation for Nonlinear/transient problems? |
Member
Author
|
@oriolcg I don't have time atm, I'll try to push this further after the summer. I am not focusing complicated problems yet, but obviously anything that assembles repeatedly (like NL or transient) would benefit from this. I am worried about the memory footprint though... I think I can make most of it lazy so that we don't have to keep any Float values in memory, but it will take take some time to work it out. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1000 +/- ##
=======================================
Coverage 88.23% 88.24%
=======================================
Files 179 179
Lines 22593 22593
=======================================
+ Hits 19936 19937 +1
+ Misses 2657 2656 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to what we discussed. @amartinhuertas @fverdugo
A little context:
The current implementation of the sparse matrix assembly is (loosely) done as follows:
InserterCSCobject, with a similar layout toSparseMatrixCSC.Both of these have the advantage of saving memory, but at the cost of doing sparse row/col index searches every time we assemble an entry.
We would like to investigate the option of working with COO-type structures. These are more expensive memory-wise, but can save quite a lot of time when re-assembling the matrix.
I've added a MWE on a possible implementation of the latter. Also, here are some results from the benchmarks at the end: