Update CxxWrap, Algoim and bump version#118
Conversation
CxxWrap was stuck at 0.16.XX, that doesn't compile on Julia 1.12 on my machine.
|
Hello @Antoinemarteau, Thanks a lot for the PR. I've just updated Algoim.jl to 0.2.3, which requires CxxWrap.jl 0.17. This works for Julia 1.12 and 1.13 as well. Could you please bump the versions in the Project.toml accordingly? If all tests pass, I'll merge. Thanks again. |
|
Actually the current Project.toml is compatible with Algoim.jl 0.2.3 (because 0.2.2 compat means [0.2.2, 0.3), so it includes 0.2.3), so I could update locally and everything works on julia 1.12. |
|
Hi, @Antoinemarteau,
Yes, please, just for simplicity. I'll soon incorporate features in GE that require Algoim.jl 0.2.3 and I can only expect people using julia 1.9 or lower to have issues with this change. |
|
Hey @ericneiva, I updated Algoim.jl to 0.2.3. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
==========================================
- Coverage 77.04% 76.83% -0.22%
==========================================
Files 31 31
Lines 3603 3600 -3
==========================================
- Hits 2776 2766 -10
- Misses 827 834 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I will merge the PR because the failed test has nothing to do with this PR. I'll investigate this separately. Thank you so much @Antoinemarteau ! |
See Gridap#1242 |
CxxWrap was stuck at 0.16.XX, that doesn't compile on Julia 1.12 on my machine. This would also prevent Algoim.jl from updating.
I suggest bumping version in order to also update Tutorial (that I can't compile on my machine).