Skip to content

Update CxxWrap, Algoim and bump version#118

Merged
ericneiva merged 2 commits intogridap:masterfrom
Antoinemarteau:master
Mar 3, 2026
Merged

Update CxxWrap, Algoim and bump version#118
ericneiva merged 2 commits intogridap:masterfrom
Antoinemarteau:master

Conversation

@Antoinemarteau
Copy link
Contributor

CxxWrap was stuck at 0.16.XX, that doesn't compile on Julia 1.12 on my machine. This would also prevent Algoim.jl from updating.

I suggest bumping version in order to also update Tutorial  (that I can't compile on my machine).

CxxWrap was stuck at 0.16.XX, that doesn't compile on Julia 1.12 on my
machine.
@ericneiva
Copy link
Member

Hello @Antoinemarteau,

Thanks a lot for the PR. I've just updated Algoim.jl to 0.2.3, which requires CxxWrap.jl 0.17. This works for Julia 1.12 and 1.13 as well.

Could you please bump the versions in the Project.toml accordingly? If all tests pass, I'll merge.

Thanks again.

@ericneiva ericneiva self-assigned this Feb 27, 2026
@Antoinemarteau
Copy link
Contributor Author

Actually the current Project.toml is compatible with Algoim.jl 0.2.3 (because 0.2.2 compat means [0.2.2, 0.3), so it includes 0.2.3), so I could update locally and everything works on julia 1.12.
Do you want I to enforce 0.2.3 in the Project.toml ?

@ericneiva
Copy link
Member

ericneiva commented Mar 2, 2026

Hi, @Antoinemarteau,

Do you want I to enforce 0.2.3 in the Project.toml ?

Yes, please, just for simplicity. I'll soon incorporate features in GE that require Algoim.jl 0.2.3 and I can only expect people using julia 1.9 or lower to have issues with this change.

@Antoinemarteau
Copy link
Contributor Author

Hey @ericneiva, I updated Algoim.jl to 0.2.3.
Thanks for your help.

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.83%. Comparing base (96f4d97) to head (c30c8c0).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   77.04%   76.83%   -0.22%     
==========================================
  Files          31       31              
  Lines        3603     3600       -3     
==========================================
- Hits         2776     2766      -10     
- Misses        827      834       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericneiva ericneiva merged commit cef0116 into gridap:master Mar 3, 2026
5 of 7 checks passed
@ericneiva
Copy link
Member

I will merge the PR because the failed test has nothing to do with this PR. I'll investigate this separately.

Thank you so much @Antoinemarteau !

@ericneiva
Copy link
Member

I will merge the PR because the failed test has nothing to do with this PR. I'll investigate this separately.

See Gridap#1242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants