Fix cairo-gtk/cairo-fb builds on macOS by using dynamic linking#3
Open
Fix cairo-gtk/cairo-fb builds on macOS by using dynamic linking#3
Conversation
On macOS (Darwin), pkg-config --static pulls in xcb/xdmcp transitive dependencies that are unavailable in Nix-based environments, causing linker failures. macOS uses dynamic libraries by default, so --static is unnecessary. Use dynamic linking (without --static) on Darwin for the cairo-gtk and cairo-fb targets.
OTP 24.2 prebuilt binaries are not available for Ubuntu 24.04, which ubuntu-latest now resolves to. Pin to ubuntu-22.04 where OTP 24.2 builds exist. Also bump actions/checkout from v3 to v4 to address Node.js 20 deprecation warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg-config --staticcauses linker failures because macOS does not support fully static linkinguname) for bothcairo-gtkandcairo-fbtargets: use dynamic linking on Darwin, static linking on LinuxTest Plan
SCENIC_LOCAL_TARGET=cairo-gtkon macOS succeedsSCENIC_LOCAL_TARGET=cairo-fbon macOS succeeds