Skip to content

Fix stale RxDone race condition in sx12xx driver #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ringlej wants to merge 1 commit into
base: gridpoint-4.3.0
Choose a base branch
from
Open

Fix stale RxDone race condition in sx12xx driver #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions drivers/lora/loramac_node/sx12xx_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,12 @@ static void sx12xx_ev_rx_done(uint8_t *payload, uint16_t size, int16_t rssi,
{
struct k_poll_signal *sig = dev_data.operation_done;

if (!dev_data.async_rx_cb && !sig) {
LOG_WRN("RxDone event with no registered consumer "
"(modem_usage=%d)",
(int)atomic_get(&dev_data.modem_usage));
}

/* Receiving in asynchronous mode */
if (dev_data.async_rx_cb) {
/* Start receiving again */
Expand Down Expand Up @@ -312,6 +318,7 @@ int sx12xx_lora_recv_async(const struct device *dev, lora_recv_cb cb, void *user
{
/* Cancel ongoing reception */
if (cb == NULL) {
dev_data.async_rx_cb = NULL;
if (!modem_release(&dev_data)) {
/* Not receiving or already being stopped */
return -EINVAL;
Expand Down
Loading