Race condition when setting delegate form react-native wrapper#1
Open
nazgu1 wants to merge 1 commit into
Open
Conversation
dobreandl
added a commit
that referenced
this pull request
Nov 13, 2025
updated events handling and prepared 2.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is race condition, as react-native wrapper sets delegate directly using Grovs.delegate. Sometimes
private static var manager: GrovsManager?is nil at the moment of setting delegate.This PR fixes this issue by storing delegate in private variable and try to set it once manager is present. I consider it rather a hacky way of solving this issue, but it is sufficient at the moment. To proper resolve it there is probably need to refactor this logic (like having delegate queue, or don't use static variables and let RN wrapper handle own instance)
Reminder:
There is need to bump Grovs-iOS version and update it in RN wrapper
.podspecfile