fix: prevent race conditions causing plain text communication#246
Merged
fix: prevent race conditions causing plain text communication#246
Conversation
Contributor
|
@eshitachandwani and @arjan-bal Please review the PR. |
Contributor
|
Apologies for the delay, have been busy last week. Will leave a review within the next couple of days. |
arjan-bal
reviewed
Apr 22, 2026
Contributor
Author
arjan-bal
reviewed
Apr 23, 2026
Contributor
Contributor
Member
|
The changes look good to me. But since we are adding a field in the function that is used by almost all the tests , can you please run one more test, other than security to make sure it is not failing anything else. Since it is an optional field, it should not affect other tests, but we should still verify. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a race condition exists where pods connect to Traffic Director before security policies are fully propagated, causing them to fallback to plaintext configurations. This leads to unrecoverable protocol mismatches (e.g., SSL wrong version number errors) in the initial attemps.
To eliminate test flakiness and avoid the need for the assertTestAppSecurityWithRetry retry loop, we must ensure that the client and server receive their intended TLS/mTLS security configurations in their very first xDS responses from Traffic Director.
Security Test Run
Authz Test Run