Fix custom ffmpeg library/header building#158
Closed
ShinyMacadamia wants to merge 1 commit into
Closed
Conversation
90b3b41 to
bfbd97e
Compare
bfbd97e to
053a26d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve this issue:
#157
In order to resolve it, i conditionally check whether
PC_FFMPEG_LIBRARY_DIRSandPC_FFMPEG_INCLUDE_DIRSare present. If library is found, it sets the variables manually:I'm almost certain this also should be checked and set manually in case
PC_FFMPEG_INCLUDE_DIRSis present:like this:
About formatting. I didn't find any cmake-format configs in the repo. Because of this, cmake-formatter with my own settings was applied. I'm not even sure how to format this exact cmake file.
Any suggestions are appreciated!