Skip to content

if dicom import produced same filenames (for some reason) inform user and stop processinng at start in denoising#136

Open
Barisevrenugur wants to merge 1 commit into
masterfrom
denoising-inputdir
Open

if dicom import produced same filenames (for some reason) inform user and stop processinng at start in denoising#136
Barisevrenugur wants to merge 1 commit into
masterfrom
denoising-inputdir

Conversation

@Barisevrenugur

Copy link
Copy Markdown
Contributor

answers #135
so if dicom import produced same filenames (for some reason- does not happen with our own demodata) across different image directories, it stops processing and warns the user to rename their files (in a way that they see appropriate) and then continue processing

@lukeje

lukeje commented Mar 17, 2026

Copy link
Copy Markdown
Member

I would suggest just making the output filenames unique using matlab.lang.makeuniquestrings, especially since it seems that this problem will keep happening with the new Siemens DICOMs. That function gives a second output which can be used to let the user know which files have been changed.

@Barisevrenugur

Copy link
Copy Markdown
Contributor Author

I shortly considered doing that too but last night did not remember that makeuniquestrings was available from R2014a (thought it was availabe more in later versions) as noted in the link you shared below, then I might modify the implementation using makeuniquestrings

I would suggest just making the output filenames unique using matlab.lang.makeuniquestrings, especially since it seems that this problem will keep happening with the new Siemens DICOMs. That function gives a second output which can be used to let the user know which files have been changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SPM/hMRI DICOM-import generates non-unique filenames causing denoising output overwriting

2 participants