When in CSRF mode get a crumb & add it to the POST headers#26
Open
nullify005 wants to merge 1 commit intohacklanta:masterfrom
Open
When in CSRF mode get a crumb & add it to the POST headers#26nullify005 wants to merge 1 commit intohacklanta:masterfrom
nullify005 wants to merge 1 commit intohacklanta:masterfrom
Conversation
|
this patch breaks support for jenkins with CSRF mode turned off. Works fine with it turned on (which is fine for me) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows hubot to get a crumb from Jenkins prior to submitting a post request (such as to launch a build) when CSRF is enabled on the server
https://wiki.jenkins.io/display/JENKINS/Remote+access+API#RemoteaccessAPI-CSRFProtection
I suppose that there should be a toggle on or off & better error checking etc. but I don't like writing coffee script it makes my head hurt