🐛 Fix interaction failures stemming from bot reset / state loss

[0xRy4n]

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

• Bugfix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality not to work as expected).
• Documentation Update (if none of the other choices applies).

Proposed changes

View interactions would fail if the bot had been reset or lost connection causing some staff actions to result in "This interaction failed" when clicking on buttons in views.

• BanDecisionView buttons now use specific custom IDs instead of static ones
• BanDecisionView constructor only takes ban ID and reconstructs additional context at call time
• Callbacks use defer() before continuing processing
• View registration

Checklist

Put an x in the boxes that apply.

• I have read and followed the CONTRIBUTING.md
  doc.
• Lint and unit tests pass locally with my changes.
• I have added the necessary documentation (if appropriate).

Additional context

[codecov]

Codecov Report

❌ Patch coverage is 80.76923% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.74%. Comparing base (131c32b) to head (8cc73bb).

Files with missing lines	Patch %	Lines
src/bot.py	15.78%	16 Missing ⚠️
src/helpers/ban.py	20.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   59.38%   61.74%   +2.36%     
==========================================
  Files          50       50              
  Lines        2903     2941      +38     
==========================================
+ Hits         1724     1816      +92     
+ Misses       1179     1125      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dimoschi]

What if get_member_or_user returns None? Should we try...except here?

[0xRy4n]

Down to preference I guess. The function itself has a bunch of exception handling to log the various possible errors, but there is no way to really handle/correct for it (beyond the logging), so it may make sense to let the exception bubble up. Whatever you prefer, really

[dimoschi]

Could make sense if member is None to return and not even try to unban. Right now, it would seem to the moderators that the member that wasn't found has been unbanned/denied.

[0xRy4n]

fair point, I will change that

[dimoschi]

LGTM, thank you @0xRy4n for taking good care!