Skip to content

wait for database user to be created before starting omero-web#6

Open
thushw wants to merge 2 commits into
hadim:masterfrom
thushw:master
Open

wait for database user to be created before starting omero-web#6
thushw wants to merge 2 commits into
hadim:masterfrom
thushw:master

Conversation

@thushw

@thushw thushw commented Feb 16, 2017

Copy link
Copy Markdown

No description provided.

@hadim

hadim commented Feb 18, 2017

Copy link
Copy Markdown
Owner

The issue with this solution is that root user with this password will not always exist. What does happen if the container is started over a previously created OMERO instance that does not have such a user/password ?

Maybe we should start using the new HEALTHCHECK feature of Docker : https://docs.docker.com/engine/reference/builder/#/healthcheck

@thushw

thushw commented Feb 25, 2017

Copy link
Copy Markdown
Author

I think that's a good idea. But I'm not sure what the health check should be looking for.

If the health check command tries to login to the server, we must be prepared for the user changing the omero config, so that might not work. Similarly we can't rely on even the credentials of the postgres user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants