feat: new_lifespan to allow configuring sqla engine directly#25
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 100 108 +8
Branches 6 7 +1
=========================================
+ Hits 100 108 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@vicrep What do you think? thanks! |
|
This is great, thanks for doing this @hadrien ! I liked the 12-factor-style-config being the default recommended approach, but for some specific setups, and nested config args (eg. that reported issue), the ergonomics of doing it fully through environ were at times lacking. |
|
Super nice, thank you for the quick fix! |
|
/songify |
|
🎵 DiffBeats just dropped a track for this PR! "feat: new_lifespan to allow configuring sqla engine directly" Lyrics |
Problem
connect_argswith environment variablesSolution
new_lifespanto allow passing sqla engine parameters directly: