Skip to content

stayOpen and stayClose API#40

Open
kennethpdev wants to merge 1 commit intohakimel:masterfrom
kennethpdev:master
Open

stayOpen and stayClose API#40
kennethpdev wants to merge 1 commit intohakimel:masterfrom
kennethpdev:master

Conversation

@kennethpdev
Copy link
Copy Markdown

As the name says, meny will stay in always open state or always close
state. can revert state by using stayOpen(false) or stayClose(false).

As the name says, meny will stay in always open state or always close
state.
We can revert state by using stayOpen(false) or stayClose(false)
@hakimel
Copy link
Copy Markdown
Owner

hakimel commented Feb 17, 2015

I tested this but was expecting those methods to also actually open and close the menu. So calling stayOpen opens the menu and keeps it open, where stayClose closes the menu and keeps it closed.

Maybe I'm misunderstanding how this is intended to be used – can you describe the use case?

Two other things:

  • stayClose should be renamed to stayClosed
  • We'll need new variable names for _stayOpen and _stayClose – no other variables in the file use underscore prefixing so these shouldn't either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants