fixing bugs in ui#22
Merged
Merged
Conversation
Comment out the install_engineer_deps call in the main setup flow while the engineer agent is paused. The function and its venv helpers remain defined, so resuming is a one-line uncomment. https://claude.ai/code/session_01THtMvNNx21QhXYi6PBRFBz
Two unrelated bugs surfaced in the GUI:
1. False "API not reachable":
- The GUI's connectivity probe hit GET /api/v1/health, which shells
out to `orchestrator.sh health all` and sweeps every tool — far
slower than the 5s fetch timeout, so the UI showed Offline.
- The server used single-threaded HTTPServer, so that slow sweep also
blocked page loads and message requests.
Fixes:
- Add a lightweight GET /api/v1/ping that returns instantly without
touching the orchestrator (added to PUBLIC_PATHS, used by the GUI).
- Switch to ThreadingHTTPServer so no single request blocks others.
2. Raw JSON in chat:
- /agent/ask is a tool ROUTER; conversational input like "hi" matches
no tool and returned {matched_tool:null, error:...}, which the GUI
dumped verbatim.
Fix:
- Add formatAgentReply() to render matched-tool and no-match responses
as human-readable text, with pre-wrap so multi-line replies display.
https://claude.ai/code/session_01THtMvNNx21QhXYi6PBRFBz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.