Development 03 by halilibrahimcelik · Pull Request #3 · halilibrahimcelik/wikimasters

halilibrahimcelik · 2026-03-02T22:34:47Z

No description provided.

…"Go Back" button in WikiEditor and update dependencies

…move unused SignUp button

…orts in ArticlesList and WikiEditor

… and update dependencies

…dd TextType component for animated text display; update dependencies

…handling and improve error logging in WikiArticleViewer

…ponent for enhanced user interaction in WikiArticleViewer

…nd WikiEditor; update layout to include Toaster component

…deleteArticleForm and add user authorization check in ViewArticlePage

vercel · 2026-03-02T22:34:52Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
wikimasters	Ready	Preview, Comment	Mar 2, 2026 11:04pm

…tip component consistency

Copilot

Pull request overview

This PR adds UI enhancements and an AI-powered article summarization flow to the wiki article viewer, along with some routing + navbar updates and improved toasts/UX around editing/deleting.

Changes:

Add /api/ai route that calls OpenRouter to summarize article content (with Zod request validation).
Add new UI components (tooltip, shiny animated text, typewriter text) and integrate them into the article viewer summary experience.
Update routing/nav/editor UX (new Routes entries, navbar “New Article” link, toasts instead of alerts, authz-based canEdit).

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
types/index.ts	Adds new route constants (`HOME`, `ARTICLES`).
pnpm-lock.yaml	Locks newly added dependencies.
package.json	Adds dependencies for AI + animations + toasts + Zod v4.
components/ui/tooltip.tsx	Introduces Base UI tooltip wrappers used across the app.
components/ui/text-type.jsx	Adds a client typewriter component used to animate summaries.
components/ui/shiny-text.jsx	Adds a motion-based “shiny text” animation component.
components/ui/link-button.tsx	Replaces dedicated sign-in/out buttons with a generic link-button wrapper.
components/ui/button.tsx	Removes the default `nativeButton={false}` override.
components/features/wikicards/wiki-editor.tsx	Replaces alerts/confirm with `sonner` toasts; adds “Go Back” link button.
components/features/wikicards/wiki-card.tsx	Adds `line-clamp-4` for article summary display.
components/features/wikicards/wiki-article-viewer.tsx	Adds summarization UI, tooltips, copy-to-clipboard, and `useActionState` delete handling.
components/features/wikicards/articles-list.tsx	Removes the “New Article” button from the list header.
components/features/navbar/signup-button.tsx	Removes the old sign-up button component.
components/features/navbar/navbar.tsx	Uses `LinkButton` + `Routes`; adds “New Article” for authenticated users.
components/features/navbar/index.ts	Stops exporting removed navbar button components.
components.json	Adds a registry entry and reorders menu config properties.
app/wiki/[id]/page.tsx	Uses `authorizeUserToEditArticle` to compute `canEdit`.
app/layout.tsx	Adds global TooltipProvider wrapper and Sonner Toaster.
app/api/ai/route.ts	Adds AI summarization API route.
app/actions/articles.ts	Updates `deleteArticleForm` signature to support `useActionState` and return an error state.
.vscode/settings.json	Adds `gsap` to spellchecker words list.
.github/workflows/main.yml	Adds `AI_GATEWAY_API_KEY` to workflow env.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (1)

components/ui/link-button.tsx:12

LinkButton is typed as React.FC, but React isn’t imported in this file. This will fail typechecking.

Import type React/FC from react, or switch to const LinkButton = ({...}: LinkButtonProps) => { ... } without referencing React.FC.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-02T22:40:01Z

+  const user = await stackServerApp.getUser({ or: "redirect" });
  // Mock permission check - in a real app, this would come from auth/user context
-  const canEdit = true; // Set to true for demonstration
-  const article = await getArticleByIdFromDB(id);
+  const userId = user?.id ?? "mockUserId";
+  const [article, canEdit] = await Promise.all([
+    getArticleByIdFromDB(id),
+    authorizeUserToEditArticle(userId, id),
+  ]);


stackServerApp.getUser({ or: "redirect" }) should guarantee a user, but this still falls back to a hard-coded "mockUserId". That can mask auth issues and may cause incorrect authorization results.

Prefer treating user as non-null after redirect (or explicitly handle the null case with a redirect/throw) and pass user.id directly.

Copilot · 2026-03-02T22:40:02Z

    "@aws-sdk/client-s3": "^3.993.0",
    "@base-ui/react": "^1.2.0",
    "@neondatabase/serverless": "^1.0.2",
+    "@openrouter/sdk": "^0.8.0",


@openrouter/sdk is added as a dependency but isn’t referenced anywhere in the codebase (the API route uses fetch directly). Keeping unused deps increases install size and supply-chain surface.

Either remove @openrouter/sdk from dependencies or switch the AI route to use the SDK so the dependency is justified.

Suggested change

"@openrouter/sdk": "^0.8.0",

Copilot · 2026-03-02T22:40:02Z

+import {
+  motion,
+  useAnimationFrame,
+  useMotionValue,
+  useTransform,
+} from "motion/react";
+import { useCallback, useEffect, useRef, useState } from "react";
+


This component uses React hooks, but the file is missing the "use client" directive. In the App Router this will cause a build/runtime error when imported into client components.

Add "use client" at the top of the file (before imports) or convert it to a server-safe component (no hooks).

Copilot · 2026-03-02T22:40:02Z

+
+          setCurrentTextIndex((prev) => (prev + 1) % textArray.length);
+          setCurrentCharIndex(0);
+          timeout = setTimeout(() => {}, pauseDuration);


The deletion->next-sentence transition sets timeout = setTimeout(() => {}, pauseDuration) which is a no-op. This both adds dead code and means pauseDuration isn’t actually used between sentences after deletion.

Either remove the no-op timeout or use it to schedule the next typing step after pauseDuration (so the pause is honored).

Suggested change

timeout = setTimeout(() => {}, pauseDuration);

timeout = setTimeout(() => {

executeTypingAnimation();

}, pauseDuration);

Copilot · 2026-03-02T22:40:03Z

+  };
+  useEffect(() => {
+    let isMounted = true;

    const fetchPageView = async () => {
      const newCount = await incrementPageViews(article.id);
-      setLocalPageViews(newCount);
-
-      if (hasSessionStorage) {
-        window.sessionStorage.setItem(storageKey, "true");
+      if (isMounted) {
+        setLocalPageViews(newCount);
      }
    };
+
    fetchPageView();
+
+    return () => {
+      isMounted = false;
+    };


incrementPageViews is now called on every mount with no per-session guard. Since incrementPageViews can trigger milestone emails, refreshing the page (or navigating back/forth) can inflate counts and spam milestone notifications.

Consider restoring the session-based dedupe (e.g., sessionStorage key) or implement server-side rate limiting/deduplication keyed by (user/session, article).

Copilot · 2026-03-02T22:40:04Z

+          variant={"default"}
+          render={(props) => (
+            <Link
+              href={!isEditing ? Routes.HOME : `/wiki/${articleId}`}


href can become /wiki/undefined when isEditing is true but articleId is missing (it’s optional in props). This produces a broken back link.

Guard the editing case (e.g., only render the article link when articleId is present, otherwise fall back to Routes.HOME).

Suggested change

href={!isEditing ? Routes.HOME : `/wiki/${articleId}`}

href={!isEditing || !articleId ? Routes.HOME : `/wiki/${articleId}`}

Copilot · 2026-03-02T22:40:04Z

+    } finally {
+      setIsSummarizing(false);
+    }
+    return () => controller.abort(); // ✅ return cleanup function to abort on unmount


handleSummarizeArticle creates an AbortController and returns a cleanup function, but returning a function from an event handler has no effect—so the request is never aborted on unmount. The handler can also still call setState after unmount.

If you want abort-on-unmount or abort on repeated clicks, store the controller in a ref and abort it in a useEffect cleanup (and/or before starting a new request). Otherwise, remove the controller/returned cleanup to avoid implying it’s handled.

Suggested change

return () => controller.abort(); // ✅ return cleanup function to abort on unmount

Copilot · 2026-03-02T22:40:04Z

      {/* Article Content */}
      <Card>
-        <CardContent className="pt-6">
+        <CardContent className="pt-20 relative max-h-150 overflow-auto">


max-h-150 isn’t a standard Tailwind utility (and it’s not defined anywhere else in the repo). This will likely be a no-op and the overflow behavior won’t apply.

Use an arbitrary value (max-h-[...]) or a standard max-height token (e.g. max-h-screen, max-h-[600px], etc.).

Suggested change

<CardContent className="pt-20 relative max-h-150 overflow-auto">

<CardContent className="pt-20 relative max-h-[150px] overflow-auto">

halilibrahimcelik · 2026-03-02T22:41:39Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-03-02T22:41:48Z

@halilibrahimcelik I've opened a new pull request, #4, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: halilibrahimcelik <92088301+halilibrahimcelik@users.noreply.github.com>

Sync pnpm-lock.yaml after removing @openrouter/sdk

halilibrahimcelik added 10 commits February 20, 2026 00:25

feat: refactor WikiArticleViewer to simplify page view tracking; add …

9c51d84

…"Go Back" button in WikiEditor and update dependencies

feat: add LinkButton component for navigation; refactor Navbar and re…

55d27ac

…move unused SignUp button

feat: refactor Navbar component; remove SignInButton and clean up imp…

a8d61d4

…orts in ArticlesList and WikiEditor

feat: enhance Navbar and Articles components; add ShinyText component…

80a3419

… and update dependencies

feat: implement article summarization feature in WikiArticleViewer; a…

69eb0d0

…dd TextType component for animated text display; update dependencies

feat: enhance AI response handling in route.ts; add validation error …

f3ed570

…handling and improve error logging in WikiArticleViewer

feat: update content validation in RequestBodySchema; add Tooltip com…

eda69f4

…ponent for enhanced user interaction in WikiArticleViewer

feat: integrate Sonner for toast notifications in WikiArticleViewer a…

a9bff8e

…nd WikiEditor; update layout to include Toaster component

feat: enhance article deletion handling; improve error management in …

bc07e2d

…deleteArticleForm and add user authorization check in ViewArticlePage

feat: add AI gateway API key to CI/CD workflow for enhanced integration

4a46a16

Copilot AI review requested due to automatic review settings March 2, 2026 22:34

vercel Bot deployed to Preview March 2, 2026 22:35 View deployment

Copilot started reviewing on behalf of halilibrahimcelik March 2, 2026 22:35 View session

feat: refactor imports and formatting in multiple files; enhance tool…

f35f9d0

…tip component consistency

vercel Bot deployed to Preview March 2, 2026 22:38 View deployment

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Initial plan

e70c0b4

Copilot AI mentioned this pull request Mar 2, 2026

Sync pnpm-lock.yaml after removing @openrouter/sdk #4

Merged

Copilot AI and others added 3 commits March 2, 2026 22:48

fix: address PR review comments - auth, deps, UX, abort, dedup, types

39c5981

Co-authored-by: halilibrahimcelik <92088301+halilibrahimcelik@users.noreply.github.com>

fix: sync pnpm-lock.yaml with package.json (remove @openrouter/sdk)

8646ae4

Co-authored-by: halilibrahimcelik <92088301+halilibrahimcelik@users.noreply.github.com>

Merge pull request #4 from halilibrahimcelik/copilot/sub-pr-3

47ca5ab

Sync pnpm-lock.yaml after removing @openrouter/sdk

vercel Bot deployed to Preview March 2, 2026 23:04 View deployment

halilibrahimcelik merged commit d4a7667 into main Mar 2, 2026
3 checks passed

	href={!isEditing ? Routes.HOME : `/wiki/${articleId}`}
	href={!isEditing \|\| !articleId ? Routes.HOME : `/wiki/${articleId}`}

	<CardContent className="pt-20 relative max-h-150 overflow-auto">
	<CardContent className="pt-20 relative max-h-[150px] overflow-auto">

Conversation

halilibrahimcelik commented Mar 2, 2026

Uh oh!

vercel Bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

halilibrahimcelik commented Mar 2, 2026

Uh oh!

Copilot AI commented Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel Bot commented Mar 2, 2026 •

edited

Loading