feat: Bakta/GFF3 support, Center button, legend drag fix, reference annotations#6
Open
happykhan wants to merge 5 commits into
Open
feat: Bakta/GFF3 support, Center button, legend drag fix, reference annotations#6happykhan wants to merge 5 commits into
happykhan wants to merge 5 commits into
Conversation
…nnotation rendering - Add GFF3 feature import (.gff3/.gff) to AnnotationEditor with same feature-type/text-filter UI as GenBank import; add extractGFF3Features() to parser.worker.ts - Add .gbff (Bakta GenBank flat file) to reference and annotation file accept attributes - Add Center button to plot toolbar (resets pan, preserves zoom) - Fix legend drag coordinate transform: CSS-px delta now correctly scaled to 1000×1000 logical space before passing to moveLegend() - Render CDS features from GenBank reference files on the inner reference ring; labels point inward via new labelInward parameter on drawAnnotations Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Deploying brigx with
|
| Latest commit: |
c44f478
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0f8b2f1a.brigx.pages.dev |
| Branch Preview URL: | https://feat-bakta-gff3-center-legen.brigx.pages.dev |
- Move Save/Load Session from NavBar into a secondary tab-strip nav below the header, styled after RonaQC (--gx-bg-alt background, accent underline pattern) - Rename ring 'Annotations' button to 'Custom Annotations' with a descriptive tooltip clarifying it's for per-ring region highlights / GenBank/GFF3 import overlays (not the reference annotation track) - Replace catch(error: any) with catch(error) + instanceof Error guard in GenBank and GFF3 import handlers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add dist/ to ESLint ignores (was producing 14+ false-positive errors from compiled output) - Add CI workflow (.github/workflows/ci.yml): type-check + lint + unit tests run on every PR and push to master - Add SECURITY.md with vulnerability reporting contact and scope notes - Fix all remaining catch(error: any) instances → catch(error) with instanceof Error guard (hooks/useBRIGController, lib/controller, workers/alignment.worker, workers/parser.worker) - Remove dead code: unused private methods parseGenome/mergeGenomes in controller.ts, unused getColorForIdentity in renderer.ts - Remove unused React import from ErrorBoundary (not needed with new JSX transform) - Add tsconfig strict flags: noUnusedLocals, noUnusedParameters, noImplicitReturns, noFallthroughCasesInSwitch - Clean up test files to satisfy new strict flags: remove dead cachedPlotData declaration, add assertions for psk57/sap014a loads, remove unused CircularPlotData import Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Project uses pixi for environment management. Replace npm ci (requires lock file) with pixi + npm install. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gbffto reference and annotation file inputs; add GFF3 feature import (.gff3/.gff) to AnnotationEditor with the same feature-type/text-filter UI as the existing GenBank import1000 / canvas.offsetWidthbeforemoveLegend()labelInwardparameter ondrawAnnotationsTest plan
.gbffBakta output as reference — GC ring appears, genome processes normally.gff3file → annotations appear.gbkreference with CDS features → CDS arrows visible on inner ring with labels🤖 Generated with Claude Code