Adopt gh 2.95.0 skill changes; require gh ≥ 2.95.0#4
Merged
Conversation
- Reload the Installed tab after a modal remove so the removed row no longer lingers until re-activation. - Bind `r` to refresh the active tab (was aliased to the log toggle); `l` alone now toggles logs. RefreshActiveTab invalidates the gh skill list cache and reloads Installed/Changes or re-runs the Discover query. - Refresh the active tab after cleanup removes or ignores skills. - Pin the RemoveScreen wizard to a percentage size so Dim.Fill content (radio list, Review/Confirm markdown) gets real space instead of collapsing to the lone fixed label. - Re-sync the remove evaluation from the live radio selection on step change and focus change, so Review/Confirm always match what's shown. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
GitHub CLI 2.95.0 shipped three skill-related changes. Adopt them: - Raise the minimum gh from 2.94.0 → 2.95.0. 2.95.0 makes `gh skill update` atomic and in-place (cli/cli#13449), fixing a bug where it could relocate namespaced skills and delete the original install dir; SkillView's Changes tab drives `gh skill update --all`. Update the constant, requirement strings (Doctor, Install, Env probe/report, CLI doctor, README, Gh service doc-comments) and tests. "Shipped in 2.94" provenance notes are left as-is. - Honor CLAUDE_CONFIG_DIR in the filesystem scanner (cli/cli#13523). gh now writes Claude user-scope skills to $CLAUDE_CONFIG_DIR/skills; ScanRootResolver adds that root (alongside ~/.claude/skills) so the scan corroborates `gh skill list`. - Add a per-repo discovery picker (cli/cli#13548). `gh skill install <repo>` run non-interactively now lists the repo's skills instead of erroring. GhSkillInstallService gains ListRepoSkillsAsync + a tolerant TSV parser + BuildInstallPlan (all skills → --all, else per-name). RepoSkillPickerModal presents a checklist (reusing InstallConfirmModal's scope/agent pickers); the `A` shortcut now discovers-then-picks via SkillViewWorkflowCoordinator.OpenRepoDiscoveryDialog, falling back to install-all if discovery fails. Tests: +10 (listing args, TSV parse, install plan, CLAUDE_CONFIG_DIR scan roots, 2.95 minimum). Full suite: 513 passing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub CLI 2.95.0 shipped three
gh skillchanges. This PR adopts them. (Also carries a pre-existing remove-flow UI fix as its own commit — see below.)What changed
Require gh ≥ 2.95.0 (cli/cli#13449)
2.95.0 makes
gh skill updateatomic and in-place, fixing a bug where it could relocate namespaced skills and delete the original install directory. SkillView's Changes tab drivesgh skill update --all, so the minimum is raised 2.94.0 → 2.95.0. UpdatedGhBinaryLocator.MinimumVersion, the user-facing requirement strings (Doctor, Install, Env probe/report, CLI doctor, README, Gh service doc-comments) and tests. "Shipped in 2.94" provenance notes are intentionally left as-is.Honor
CLAUDE_CONFIG_DIR(cli/cli#13523)gh now writes Claude user-scope skills to
$CLAUDE_CONFIG_DIR/skills. The filesystem scanner hardcoded~/.claude/skillsand would miss them (degrading them togh skill list-only records).ScanRootResolvernow also scans$CLAUDE_CONFIG_DIR/skillswhen the env var is set, alongside the default location.Per-repo discovery picker (cli/cli#13548)
gh skill install <repo>run non-interactively now lists the repo's skills instead of erroring. New capability:GhSkillInstallService.ListRepoSkillsAsync+ a tolerant TSV parser +BuildInstallPlan(all selected →--all, else per-name).RepoSkillPickerModal— a checklist (Space toggles,A/Nselect all/none) reusingInstallConfirmModal's scope/agent pickers.Ashortcut now discovers-then-picks viaSkillViewWorkflowCoordinator.OpenRepoDiscoveryDialog, falling back to install-all if discovery fails or the repo lists nothing.This also closes a latent pitfall:
skillview install <repo>(no skill, no--all) now lists rather than errors — the picker is the intended consumer.Commits
fix(ui)— pre-existing remove-flow fixes (RemoveScreen sizing/selection sync,r→refresh rebind, post-remove/cleanup tab reload). Bundled here as a separate commit.feat(gh)— the gh 2.95.0 adoption above.Testing
CLAUDE_CONFIG_DIRscan roots, 2.95 minimum). Solution builds clean.Aon a Discover result).🤖 Generated with Claude Code