feat(sql): add DDL support, custom tables, and WHERE filter fixes#2
Merged
Conversation
harehare
commented
Jun 3, 2026
harehare
commented
Owner
- Add CREATE TABLE (empty or AS SELECT), INSERT INTO, DROP TABLE [IF EXISTS]
- Add DESC/DESCRIBE and SHOW TABLES commands
- Add DocumentStore::register_table / unregister_table for programmatic custom tables
- Use RwLock for custom_tables so SqlEngine can execute DDL via &DocumentStore
- Fix to_table() newline normalization: replace \n/\r in cells to prevent layout breaks
- Fix analyze_where_for_index: DepthExact(0) and LangExact("") now fall back to FullScan, preventing false-negative results for non-heading and non-code blocks
- Add CREATE TABLE (empty or AS SELECT), INSERT INTO, DROP TABLE [IF EXISTS]
- Add DESC/DESCRIBE and SHOW TABLES commands
- Add DocumentStore::register_table / unregister_table for programmatic custom tables
- Use RwLock<HashMap> for custom_tables so SqlEngine can execute DDL via &DocumentStore
- Fix to_table() newline normalization: replace \n/\r in cells to prevent layout breaks
- Fix analyze_where_for_index: DepthExact(0) and LangExact("") now fall back to FullScan,
preventing false-negative results for non-heading and non-code blocks
- Collapse nested if-let + if into a single if-let with && guard - Extract complex RwLock<HashMap<String, (Vec<String>, Vec<Vec<String>>)>> into a CustomTable type alias to address type_complexity warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.