Support connection pooling (thread safe) & auto discovery#239
Merged
Conversation
Surgo
force-pushed
the
topic/support_pool_auto_discovery
branch
from
613a5cd to
37571bc
Compare
Surgo
commented
Nov 2, 2025
| name: Publish to PyPi | ||
| runs-on: ubuntu-latest | ||
| environment: | ||
| name: pypi |
Author
There was a problem hiding this comment.
| logger = logging.getLogger(__name__) | ||
|
|
||
| # Accept either host:port or [IPv4]:port | ||
| _AWS_CONFIGURATION_ENDPOINT_PATTERN = re.compile( |
Author
There was a problem hiding this comment.
| logger.warning("Exception occurred while closing ElastiCache client", exc_info=True) | ||
|
|
||
| def _close_configuration_endpoint_client(self) -> None: | ||
| if not self._configuration_endpoint_client: |
Author
There was a problem hiding this comment.
📝 Django closes connection every requests 🤔
| ) | ||
|
|
||
|
|
||
| class _ConfigurationEndpointClient: |
Author
There was a problem hiding this comment.
📝 Thread un-safe, connection pooling not supported (ignore options) 🤔
| if old_client: | ||
| old_clients.append(old_client) | ||
|
|
||
| self.hasher.remove_node(client_key) |
Author
There was a problem hiding this comment.
Surgo
commented
Nov 2, 2025
| R = TypeVar("R") | ||
|
|
||
|
|
||
| def _retry_refresh_clients( |
| use_vpc_ip_address=use_vpc_ip_address, | ||
| ) | ||
|
|
||
| self._configuration_endpoint_client = RetryingClient( |
Surgo
commented
Nov 2, 2025
| return | ||
|
|
||
| now = time.monotonic() | ||
| if not force and (now - self._last_discovery_time) < self._discovery_interval: |
Author
There was a problem hiding this comment.
📝 Auto (only first time) discovery 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About