Skip to content

src/hashbang.sh: Support absent private keys#175

Open
KellerFuchs wants to merge 2 commits into
masterfrom
kellerfuchs/no-private-key
Open

src/hashbang.sh: Support absent private keys#175
KellerFuchs wants to merge 2 commits into
masterfrom
kellerfuchs/no-private-key

Conversation

@KellerFuchs

@KellerFuchs KellerFuchs commented May 8, 2023

Copy link
Copy Markdown
Member

This will make things work for users with smartcards and equivalents
... or apparently those running the signup script on a remote machine with SSH agent forwarding. 😅

@KellerFuchs KellerFuchs requested a review from RyanSquared May 8, 2023 04:17
@KellerFuchs

Copy link
Copy Markdown
Member Author

@alexlehm Could you try this and confirm it fixes your issue?
The script can be run directly from src/hashbang.sh,
or by fetching static/index.html and using gpg to validate and remove the signature.

@alexlehm

Copy link
Copy Markdown

@KellerFuchs yes, it works now for my setup

@KellerFuchs

Copy link
Copy Markdown
Member Author

@RyanSquared If you could review/merge/build/push at some point that'd be swell ;3

still hasn't had the spoons to make podman work over Tor, to push images.

@RyanSquared

Copy link
Copy Markdown
Member

I've approved this but I'm unsure of why GitHub isn't happy with it. It is saying the commits are not signed. However, git verify-commit $(git log --format=%H origin/master..HEAD) shows they are all signed.

@daurnimator

Copy link
Copy Markdown
Member

It is saying the commits are not signed. However, git verify-commit $(git log --format=%H origin/master..HEAD) shows they are all signed.

github cares too much about the UID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants