Skip to content

perf: default stmt to func #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-swirldslabs merged 4 commits into from
May 15, 2026
Merged

perf: default stmt to func #827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
950f8b6
Adding a benchmark to test parsers (GenericParserQuickBench)
ldintr May 13, 2026
95af07d
Have default cases be their own function
ldintr May 14, 2026
c70cb08
Put some cases inside generateFieldCaseStatementPacked into its own f…
ldintr May 14, 2026
96800f7
refactor: applied suggested changes in PR 827
ldintr May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...mpiler/src/main/java/com/hedera/pbj/compiler/impl/generators/protobuf/CodecGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ public void generate(
writer.addImport("static com.hedera.pbj.runtime.ProtoConstants.*");
writer.addImport("static com.hedera.pbj.runtime.Utf8Tools.*");

var sbFunc = new StringBuilder();

// spotless:off
writer.append("""
/**
Expand Down Expand Up @@ -164,14 +166,15 @@ public void generate(
.replace("$codecClass", codecClassName)
.replace("$cacheableSupport", cacheableSupport)
.replace("$unsetOneOfConstants", CodecParseMethodGenerator.generateUnsetOneOfConstants(fields))
.replace("$parseMethod", CodecParseMethodGenerator.generateParseMethod(modelClassName, schemaClassName, fields, !cacheableSupport.isBlank()))
.replace("$parseMethod", CodecParseMethodGenerator.generateParseMethod(sbFunc, modelClassName, schemaClassName, fields, !cacheableSupport.isBlank()))
.replace("$writeMethod", writeMethod)
.replace("$writeByteArrayMethod", writeByteArrayMethod)
.replace("$measureDataMethod", CodecMeasureDataMethodGenerator.generateMeasureMethod(modelClassName, fields))
.replace("$measureRecordMethod", CodecMeasureRecordMethodGenerator.generateMeasureMethod(modelClassName, fields))
.replace("$fastEqualsMethod", CodecFastEqualsMethodGenerator.generateFastEqualsMethod(modelClassName, fields))
.replace("$getDefaultInstanceMethod", generateGetDefaultInstanceMethod(modelClassName))
);
writer.append(sbFunc.toString());
// spotless:on

for (final var item : msgDef.messageBody().messageElement()) {
Expand Down
Loading
Loading