Skip to content

fix: Allow JSON parsing of snake_case field names #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-swirldslabs merged 2 commits into from
May 19, 2026
+15 −2
Merged

fix: Allow JSON parsing of snake_case field names #832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b180ed
- convert json field name to camelCase before matching to protobuf ob…
berryware May 19, 2026
ae29060
- revert the bytesAndString.proto
berryware May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...main/java/com/hedera/pbj/compiler/impl/generators/json/JsonCodecParseMethodGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ static String generateParseObjectMethod(final String modelClassName, final List<
// -- EXTRACT VALUES FROM PARSE TREE ---------------------------------------------

for (JSONParser.PairContext kvPair : root.pair()) {
switch (kvPair.STRING().getText()) {
switch (toJsonFieldName(kvPair.STRING().getText())) {
$caseStatements
default: {
if (strictMode) {
Expand Down
15 changes: 14 additions & 1 deletion pbj-integration-tests/src/test/java/com/hedera/pbj/integration/test/JsonCodecTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public void everythingTest() throws Exception {
}

@Test
public void NullStringTest() throws Exception {
public void nullStringTest() throws Exception {
final String json = """
{
"bytesField": "308201a2300d06092a86",
Expand All @@ -136,4 +136,17 @@ public void NullStringTest() throws Exception {
assertNotEquals(0, bytesAndString.bytesField().length());
assertTrue(bytesAndString.stringField().isEmpty());
}

@Test
public void snakeCaseStringTest() throws Exception {
final String json = """
{
"bytesField": "308201a2300d06092a86",
"string_field": "snake_case"
}
""";
MessageWithBytesAndString bytesAndString = MessageWithBytesAndString.JSON.parse(Bytes.wrap(json));
assertNotEquals(0, bytesAndString.bytesField().length());
assertEquals("snake_case", bytesAndString.stringField());
}
}
Loading