feat: RandomAccessData.put methods#837
Open
anthony-swirldslabs wants to merge 1 commit into
Open
Conversation
Signed-off-by: Anthony Petrov <anthony@swirldslabs.com>
JUnit Test Report 521 files ± 0 521 suites ±0 30s ⏱️ +2s Results for commit a9acfaa. ± Comparison against base commit 03830e4. This pull request removes 6 and adds 23 tests. Note that renamed tests count towards both. |
Integration Test Report 426 files ±0 426 suites ±0 16m 10s ⏱️ - 3m 25s Results for commit a9acfaa. ± Comparison against base commit 03830e4. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Introducing new
RandomAccessData.put*()methods for absolute writes into RandomAccessData objects. By default the methods throw an exception, and this works perfectly for the immutableByteswhich implements this interface. Other implementations, such asBufferedDataandMemoryDatahave overrides that implement actual put operations.The methods are:
putByte(long, byte),putBytes(long, byte[]),putBytes(long, byte[], int, int),putLong(long, long), andputVarLong(long, long)which is the minimum set of methods that could be immediately useful in the MerkleDB implementation in the Consensus Node. If necessary, we can add methods for other types (float, String, and whatnot) in the future.Unit tests are updated to verify all the new methods.
Related issue(s):
Fixes #790
Notes for reviewer:
All tests should pass.
Checklist