chore(e2e): aws_ssh_keypair module - generate unique ssh key in terraform#6300
Closed
chore(e2e): aws_ssh_keypair module - generate unique ssh key in terraform#6300
Conversation
d28ae61 to
606b537
Compare
576afa2 to
bbd72f2
Compare
bbd72f2 to
5a88245
Compare
Collaborator
|
making a new pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://hashicorp.atlassian.net/browse/ICU-17258
The purpose of this PR is to remove the need of enos variable
aws_ssh_keypair_namefor building enos scenarios. Currently it is using a locally created/stored ssh key from where the scenario is launched.This PR creates a new enos terraform module
aws_ssh_keypair. This module creates a unique ssh key, and stores it in the enos tmp folder. This module needs to be executed in the beginning of most enos scenarios; the key name, key path, and key will then be passed to resource modules in the scenario that requires it.module.aws_ssh_keypairhas 3 outputskey_pair_nameprivate_key_pathprivate_key_pemkey_pair_name&private_key_pempassed into most resource modules. most of those modules requires theprivate_key_pemfor transport blocks.private_key_pathneeded for output intest_e2emodulePCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.