Skip to content

chore(e2e): aws_ssh_keypair module - generate unique ssh key in terraform#6300

Closed
wongtonyb wants to merge 9 commits intomainfrom
wongtonyb-enos-ssh-keypair
Closed

chore(e2e): aws_ssh_keypair module - generate unique ssh key in terraform#6300
wongtonyb wants to merge 9 commits intomainfrom
wongtonyb-enos-ssh-keypair

Conversation

@wongtonyb
Copy link
Copy Markdown
Collaborator

@wongtonyb wongtonyb commented Dec 12, 2025

Description

https://hashicorp.atlassian.net/browse/ICU-17258

The purpose of this PR is to remove the need of enos variable aws_ssh_keypair_name for building enos scenarios. Currently it is using a locally created/stored ssh key from where the scenario is launched.

This PR creates a new enos terraform module aws_ssh_keypair. This module creates a unique ssh key, and stores it in the enos tmp folder. This module needs to be executed in the beginning of most enos scenarios; the key name, key path, and key will then be passed to resource modules in the scenario that requires it.

module.aws_ssh_keypair has 3 outputs

  • key_pair_name
  • private_key_path
  • private_key_pem

key_pair_name & private_key_pem passed into most resource modules. most of those modules requires the private_key_pem for transport blocks.

private_key_path needed for output in test_e2e module

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.
    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@wongtonyb wongtonyb changed the title generate aws key pair in enos chore(e2e): aws_ssh_keypair module - generate unique ssh key in terraform Dec 16, 2025
@wongtonyb wongtonyb force-pushed the wongtonyb-enos-ssh-keypair branch 2 times, most recently from d28ae61 to 606b537 Compare December 17, 2025 18:55
@wongtonyb wongtonyb added the pr/no-milestone Ignores the Milestone Check label Dec 17, 2025
@moduli moduli force-pushed the wongtonyb-enos-ssh-keypair branch from 576afa2 to bbd72f2 Compare April 7, 2026 21:39
@moduli moduli force-pushed the wongtonyb-enos-ssh-keypair branch from bbd72f2 to 5a88245 Compare April 13, 2026 20:00
@moduli
Copy link
Copy Markdown
Collaborator

moduli commented Apr 13, 2026

making a new pr

@moduli moduli closed this Apr 13, 2026
@moduli moduli deleted the wongtonyb-enos-ssh-keypair branch April 13, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-milestone Ignores the Milestone Check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants