add clarification to the PR process regarding feature branches#4
Open
rebeccaskinner wants to merge 1 commit intomainfrom
Open
add clarification to the PR process regarding feature branches#4rebeccaskinner wants to merge 1 commit intomainfrom
rebeccaskinner wants to merge 1 commit intomainfrom
Conversation
Comment on lines
+9
to
+10
| This section addresses pull requests into the the production branch (`master`). No particular process is enforced for merges into feature branches. | ||
|
|
Contributor
There was a problem hiding this comment.
This is a good clarification, thanks.
Comment on lines
+23
to
+24
| Committee members should exercise good judgement on what constitutes working together for the sake of this process. Pairing on a call or tightly collaborating asynchronously probably count. A committee member having contributed to a feature branch several weeks before it is ready to be merged probably doesn't count. | ||
|
|
Contributor
There was a problem hiding this comment.
As discussed in the call today I'll submit a PR clarify approval of the uncontroversial changes.
Contributor
There was a problem hiding this comment.
I think that after https://github.com/haskell-org/committee/pull/7/files this new paragraph is actually redundant. We don't phrase the policy in terms of "working together" any more.
Member
|
The feature branch note makes sense 100%. The other clarification paragraph seems reasonable, but not necessary if we got with @tomjaguarpaw's suggestion, which I'm in favor of :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggests some clarification to the PR process around feature branches. It is not intended to change the policy in any specific way, and instead only seeks to add some additional clarification related to long-lived feature branches.