feat: Pause point wait command is now await-pause-point#1698
Merged
Conversation
Align the native runner command name with the shorter await verb while keeping IPC bridge commands unchanged. Refresh shared release-input stamps because cli/common changed. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep Tool Settings linkage and native tool catalog entries aligned with the await-pause-point command rename. Mark the old uloop-wait-for-pause-point skill directory as deprecated so installs remove stale copies. Co-authored-by: Cursor <cursoragent@cursor.com>
Expose await-pause-point via frontmatter so Tool Settings and skill sync stay wired after the command rename. Regenerate installed skill copies and drop the deprecated uloop-wait-for-pause-point directories. Co-authored-by: Cursor <cursoragent@cursor.com>
Document the renamed native wait command in ubiquitous language notes. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (3)
📝 WalkthroughWalkthroughThe pause-point command is renamed from ChangesPause-point command rename
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
cli/dispatcher/internal/dispatcher/help_test.go (1)
401-409: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueTest name and error messages still reference "wait" instead of "await".
The test function
TestRunDispatcherPausePointWaitHelpShowsDescriptionAndOptionsand its internalt.Fatalfmessages (lines 404, 415) still say "pause-point-wait", while the command is nowawait-pause-point. Consider renaming for consistency to avoid confusion when debugging failures.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cli/dispatcher/internal/dispatcher/help_test.go` around lines 401 - 409, Rename TestRunDispatcherPausePointWaitHelpShowsDescriptionAndOptions to use “Await” consistently, and update its t.Fatalf messages to reference the await-pause-point command rather than “pause-point-wait.” Keep the test behavior and assertions unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@cli/dispatcher/internal/dispatcher/help_test.go`:
- Around line 401-409: Rename
TestRunDispatcherPausePointWaitHelpShowsDescriptionAndOptions to use “Await”
consistently, and update its t.Fatalf messages to reference the
await-pause-point command rather than “pause-point-wait.” Keep the test behavior
and assertions unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0570464c-c2fa-408a-9d74-4ce89fc60a2f
📒 Files selected for processing (40)
.agents/skills/uloop-execute-dynamic-code/SKILL.md.agents/skills/uloop-get-logs/SKILL.md.agents/skills/uloop-pause-point/SKILL.md.agents/skills/uloop-simulate-keyboard/SKILL.md.agents/skills/uloop-simulate-mouse-input/SKILL.md.agents/skills/uloop-simulate-mouse-ui/SKILL.md.claude/skills/uloop-execute-dynamic-code/SKILL.md.claude/skills/uloop-get-logs/SKILL.md.claude/skills/uloop-pause-point/SKILL.md.claude/skills/uloop-simulate-keyboard/SKILL.md.claude/skills/uloop-simulate-mouse-input/SKILL.md.claude/skills/uloop-simulate-mouse-ui/SKILL.mdAssets/Tests/Editor/PausePointTests.csAssets/Tests/Editor/SkillInstallLayoutTests.csAssets/Tests/Editor/ToolSettingsUseCaseTests.csPackages/src/Editor/Application/UseCases/ToolSettingsUseCase.csPackages/src/Editor/CliOnlyTools~/PausePoint/Skill/SKILL.mdPackages/src/Editor/Domain/ToolSettingsToolLinkPolicy.csPackages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Skill/SKILL.mdPackages/src/Editor/FirstPartyTools/GetLogs/Skill/SKILL.mdPackages/src/Editor/FirstPartyTools/SimulateKeyboard/Skill/SKILL.mdPackages/src/Editor/FirstPartyTools/SimulateMouseInput/Skill/SKILL.mdPackages/src/Editor/FirstPartyTools/SimulateMouseUi/Skill/SKILL.mdPackages/src/Editor/Infrastructure/SkillSetup/SkillTargetInstaller.csPackages/src/Editor/ToolContracts/UnityCliLoopConstants.cscli/common/clicore/command_errors_test.gocli/common/clicore/command_registry.gocli/common/clicore/command_registry_test.gocli/dispatcher/internal/dispatcher/command_help.gocli/dispatcher/internal/dispatcher/completion_options.gocli/dispatcher/internal/dispatcher/help_test.gocli/dispatcher/internal/dispatcher/skills.gocli/dispatcher/shared-inputs-stamp.jsoncli/project-runner/internal/projectrunner/native_tool_settings.gocli/project-runner/internal/projectrunner/pause_point_errors.gocli/project-runner/internal/projectrunner/pause_point_wait.gocli/project-runner/internal/projectrunner/pause_point_wait_test.gocli/project-runner/internal/projectrunner/runner_commands.gocli/project-runner/shared-inputs-stamp.jsondocs/glossary.md
Avoid agents treating uloop pause-point as a runnable CLI command by matching the heading style used by other skills. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wait-for-pause-pointtoawait-pause-pointwith no backward-compatible alias.uloop-pause-pointwith explicittoolName: await-pause-pointso Tool Settings and skill sync stay aligned.User Impact
uloop await-pause-pointinstead of the removedwait-for-pause-pointcommand.skills installremoves staleuloop-wait-for-pause-pointdirectories and installsuloop-pause-point.enable-pause-point,clear-pause-point, andpause-point-statusare unchanged.Changes
PausePointAwaitCommandName, runner/dispatcher wiring, deprecated skill cleanup list.COMMAND_NAME_AWAIT_PAUSE_POINT, Tool Settings linkage, deprecated skill cleanup list..claude/.agentscopies.Verification
scripts/check-go-cli.shdist/darwin-arm64/uloop compile --project-path <repo>uloop run-tests(EditMode regex: PausePointTests|ToolSettingsUseCaseTests|SkillInstallLayoutTests) — 60 passeduloop skills install --claude --agents— deprecated removed: 1 per targetuloop wait-for-pause-point→ UNKNOWN_COMMANDuloop await-pause-point --helpsucceedsMade with Cursor