Skip to content

fix: Tool Settings pause-point toggle now gates every pause point command#1700

Merged
hatayama merged 3 commits into
v3-betafrom
feat/pause-point-settings-tool-name
Jul 12, 2026
Merged

fix: Tool Settings pause-point toggle now gates every pause point command#1700
hatayama merged 3 commits into
v3-betafrom
feat/pause-point-settings-tool-name

Conversation

@hatayama

@hatayama hatayama commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Summary

Refs: pause-point rename plan (wave 2) — Tool Settings logical tool name

  • Rename the Tool Settings toggle and disabledTools storage key from await-pause-point to pause-point, matching the pause point family it controls.
  • Route await-pause-point and pause-point-status through the shared settings key on the Go runner so disabled toggles reject both commands (fixes a pre-existing gap where pause-point-status bypassed the gate).
  • Drop the explicit toolName: await-pause-point skill override so uloop-pause-point naturally derives pause-point for skill sync and Show Details.

Test plan

  • scripts/check-go-cli.sh
  • uloop compile — zero errors/warnings
  • EditMode: ToolSettingsUseCaseTests, SkillInstallLayoutTests
  • CLI: pause-point in disabledTools rejects both await-pause-point and pause-point-status with TOOL_DISABLED
  • Unity Tool Settings UI shows pause-point with skill description (manual)

Made with Cursor

Review in cubic

hatayama and others added 3 commits July 12, 2026 09:18
Use pause-point as the logical settings tool name so the UI toggle
matches the pause point family it controls, and route await-pause-point
through the same aggregated disable key.

Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve await-pause-point and pause-point-status to the shared
pause-point disabledTools entry so runner-side gating matches Unity,
including regression coverage for pause-point-status rejection.

Co-authored-by: Cursor <cursoragent@cursor.com>
Remove the explicit await-pause-point toolName override so skill sync
and Tool Settings descriptions align with the pause-point settings key.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2b890035-7236-4998-ba3a-56e524bece88

📥 Commits

Reviewing files that changed from the base of the PR and between f1d0a9d and 3d50484.

📒 Files selected for processing (11)
  • .agents/skills/uloop-pause-point/SKILL.md
  • .claude/skills/uloop-pause-point/SKILL.md
  • Assets/Tests/Editor/SkillInstallLayoutTests.cs
  • Assets/Tests/Editor/ToolSettingsUseCaseTests.cs
  • Packages/src/Editor/Application/UseCases/ToolSettingsUseCase.cs
  • Packages/src/Editor/CliOnlyTools~/PausePoint/Skill/SKILL.md
  • Packages/src/Editor/Domain/ToolSettingsToolLinkPolicy.cs
  • Packages/src/Editor/ToolContracts/UnityCliLoopConstants.cs
  • cli/project-runner/internal/projectrunner/native_tool_settings.go
  • cli/project-runner/internal/projectrunner/pause_point_wait_test.go
  • cli/project-runner/internal/projectrunner/runner_commands.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pause-point-settings-tool-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama hatayama changed the title Unify pause-point Tool Settings logical tool name fix: Tool Settings pause-point toggle now gates every pause point command Jul 12, 2026
@hatayama hatayama merged commit 8785326 into v3-beta Jul 12, 2026
10 checks passed
@hatayama hatayama deleted the feat/pause-point-settings-tool-name branch July 12, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant