feat: Prompt to remove the temporary V3 migration skill after docs are migrated#1711
Merged
Merged
Conversation
The temporary skill can linger in agent folders after docs and scripts are migrated. Auto-removal is unsafe because C# scan results do not mean the skill is finished, so guide removal instead: the skill workflow reports the uninstall command when searches find zero V2 candidates, and the migration wizard shows a temporary-skill note while it is installed.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe migration wizard now displays a temporary AI migration skill note for all installation states except ChangesTemporary migration skill note
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant ThirdPartyToolMigrationWizardView
participant ThirdPartyToolMigrationWizardStateRules
participant temporaryNoteTextField
ThirdPartyToolMigrationWizardView->>ThirdPartyToolMigrationWizardStateRules: evaluate installState
ThirdPartyToolMigrationStateRules-->>ThirdPartyToolMigrationWizardView: return visibility decision
ThirdPartyToolMigrationWizardView->>temporaryNoteTextField: set visible state
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@Packages/src/Editor/Presentation/Setup/ThirdPartyToolMigrationWizardStateRules.cs`:
- Around line 106-111: Update the test covering ShouldShowTemporarySkillNote to
include SkillInstallState.Checking and assert the transitional UI behavior where
the temporary note is shown alongside the Install Migration Skill button text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 66d7c6ec-79b5-4c70-ac33-8914f4fce69b
📒 Files selected for processing (5)
Assets/Tests/Editor/ThirdPartyToolMigrationWizardWindowTests.csPackages/src/Editor/Presentation/Setup/ThirdPartyToolMigrationWizardStateRules.csPackages/src/Editor/Presentation/Setup/ThirdPartyToolMigrationWizardText.csPackages/src/Editor/Presentation/Setup/ThirdPartyToolMigrationWizardView.csPackages/src/TemporarySkills~/v3-cli-invocation-migration/Skill/SKILL.md
CodeRabbit noted that ShouldShowTemporarySkillNote returns true for Checking while the button still shows Install. Lock that transitional behavior with an explicit test case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v3-cli-invocation-migrationskill finishes its job, agents are instructed to tell the user how to uninstall it (never uninstall automatically).User Impact
.claude//.agents/forever with no in-product reminder, and only a manual Remove action existed without guidance after use.Changes
uloop skills uninstall-v3-migration --<target>and do not uninstall automatically.ShouldShowTemporarySkillNote(SkillInstallState)pure rule + constant copy under the skill button row when state is not Missing.Verification
dist/darwin-arm64/uloop compile→ Success, 0 errors / 0 warningsdist/darwin-arm64/uloop run-tests --filter-type regex --filter-value "ShouldShowTemporarySkillNote|ThirdPartyToolMigrationWizardWindowTests"→ 58 passeduloop skills install-v3-migration --claude→ generated.claude/skills/v3-cli-invocation-migration/SKILL.mdcontains the uninstall guidance stepinstallState=Installed; noteVisible=True), screenshot:.uloop/outputs/Screenshots/Unity CLI Loop Migration_20260712_114203_179.pnguloop skills uninstall-v3-migration --claude:installState=Missing; noteVisible=False