Skip to content

🔒 [security fix] Sanitize appID to prevent log injection #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hatimhtm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🔒 [security fix] Sanitize appID to prevent log injection #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Click2Minimize/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,9 @@ class AppDelegate: NSObject, NSApplicationDelegate {
let sizeHeight = sizeDescriptor.atIndex(2)?.doubleValue ?? 0

// Extract app ID (name)
let appID = appIDDescriptor.stringValue ?? "Unknown"
let rawAppID = appIDDescriptor.stringValue ?? "Unknown"
// Sanitize appID to prevent Log Injection and other control-character based attacks
let appID = rawAppID.components(separatedBy: .controlCharacters).joined()

let rect = NSRect(x: positionX, y: positionY, width: sizeWidth, height: sizeHeight)
let dockItem = DockItem(rect: rect, appID: appID)
Expand Down