Skip to content

Upgrade to sequelize v4#5

Open
davidvanleeuwen wants to merge 3 commits into
hauru:masterfrom
davidvanleeuwen:master
Open

Upgrade to sequelize v4#5
davidvanleeuwen wants to merge 3 commits into
hauru:masterfrom
davidvanleeuwen:master

Conversation

@davidvanleeuwen

Copy link
Copy Markdown

@hauru

hauru commented Jun 19, 2017

Copy link
Copy Markdown
Owner

Thanks. Will be resolving this shortly. I'd like to get the update smoothed out so as the module could still be used with Sequelize 3.x.

@davidvanleeuwen

davidvanleeuwen commented Jun 19, 2017

Copy link
Copy Markdown
Author

@hauru True. The easiest way for people to keep on working would be doing a version bump to e.g. to 1.0.0 (as most people install packages with ^, and therefor people will have to specify this new version for v4) or the other way around were we explicitly say this in the readme that this is now for v4 and you should use 0.10.2 if you're not on v4. What do you think?

@hauru

hauru commented Jun 19, 2017

Copy link
Copy Markdown
Owner

@davidvanleeuwen Actually the changes are not overly dramatic from our point of view and both versions of Sequelize can be easily supported along each other. I've created a separate branch for the time being. This has yet to be tested with Sequelize 4. Also there are other minor changes that i may need to take into account, like those related to data types.

@yelled3

yelled3 commented Jun 26, 2017

Copy link
Copy Markdown

LGTM

@hauru

hauru commented Jun 26, 2017

Copy link
Copy Markdown
Owner

Changes from the aforementioned branch are now in master and in NPM. @davidvanleeuwen thanks for your input! Although I didn't do a merge, your edits were helpful.

@davesag

davesag commented May 9, 2018

Copy link
Copy Markdown

You might want to close this PR given you've incorporated its main features already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants