Resolve various (engine) hours issues#27
Merged
Conversation
- use static JSON imports for locale files to ensure production availability - fallback to first notes line as title for orphaned service logs - reorder PDF entry structure: bold title first, then meta - add cost display to PDF entries with locale-aware formatting
- initialize `next_due_measurement` for hours trackers - remove distance-only guards in tracker status computation - remove hardcoded basis from odometer triggers - set unit-aware DUE_SOON window (1h for hours, 50km for distance) - use vehicle odometer unit in warning messages - patch existing trackers with null `next_due_measurement`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found issues where the code assumed all trackers used distance, breaking things for hours-based ones. This PR will add guards, triggers, and messages to handle both distance and hours properly, and patched old data to match.